From: Leif Lindholm <leif.lindholm@linaro.org>
To: Girish Pathak <girish.pathak@arm.com>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
nd@arm.com
Subject: Re: [PATCH v3 00/16] Update GOP
Date: Mon, 23 Apr 2018 18:11:48 +0100 [thread overview]
Message-ID: <20180423171148.nfe5ntsm2paown67@bivouac.eciton.net> (raw)
In-Reply-To: <20180320161212.79120-1-girish.pathak@arm.com>
On Tue, Mar 20, 2018 at 04:11:56PM +0000, Girish Pathak wrote:
> This patch series addresses comments on the patch v2
> (https://lists.01.org/pipermail/edk2-devel/2017-December/019389.html)
> reworking of the Graphics Output Protocol code in ArmPlatformPkg.
> It also contains updates for the new SCMI protocol.
>
> Corresponding edk2-platforms changes will follow shortly.
>
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as ee4dc24f57..4f2494cf53.
Apologies for the delay in getting this through.
/
Leif
> Code is available for examination at:
> https://github.com/girishpathak/edk2/tree/201_gop_v3
>
> Girish Pathak (16):
> ArmPlatformPkg: Rectify line endings of LcdHwNullLib
> ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib
> ArmPlatformPkg: Tidy Lcd code: Coding standard
> ArmPlatformPkg: Tidy Lcd code: Updated comments
> ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS
> ArmPlatformPkg: PL111Lcd: Replace magic number with macro
> ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl
> ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP
> ArmPlatformPkg: Redefine LcdPlatformGetTimings function
> ArmPlatformPkg: Add PCD to select pixel format
> ArmPlatformPkg: PCD to swap red/blue format for HDLCD
> ArmPlatformPkg: Additional display modes
> ArmPlatformPkg: Reserving framebuffer at build
> ArmPlatformPkg: New DP500/DP550/DP650 GOP driver
> ArmPkg: MTL Library interface and Null library implementation
> ArmPkg: Introduce SCMI protocol
>
> ArmPkg/ArmPkg.dec | 16 +-
> ArmPkg/ArmPkg.dsc | 6 +-
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h | 46 ++
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h | 84 ++++
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 53 +++
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h | 55 +++
> ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 262 +++++++++++
> ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 318 ++++++++++++++
> ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 418 ++++++++++++++++++
> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 138 ++++++
> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h | 41 ++
> ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c | 457 ++++++++++++++++++++
> ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 174 ++++++++
> ArmPkg/Include/Library/ArmMtlLib.h | 137 ++++++
> ArmPkg/Include/Protocol/ArmScmi.h | 27 ++
> ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 174 ++++++++
> ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 218 ++++++++++
> ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h | 265 ++++++++++++
> ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.c | 108 +++++
> ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf | 26 ++
> ArmPlatformPkg/ArmPlatformPkg.dec | 21 +-
> ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +-
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 197 +++++----
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 10 +-
> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 177 ++++++--
> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 409 ++++++++++++++++++
> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.h | 243 +++++++++++
> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 43 ++
> ArmPlatformPkg/Library/HdLcd/HdLcd.c | 174 ++++----
> ArmPlatformPkg/Library/HdLcd/HdLcd.h | 23 +-
> ArmPlatformPkg/Library/HdLcd/HdLcd.inf | 4 +-
> ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c | 150 +++----
> ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c | 243 +++++++----
> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 125 ++++--
> 34 files changed, 4413 insertions(+), 433 deletions(-)
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c
> create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
> create mode 100644 ArmPkg/Include/Library/ArmMtlLib.h
> create mode 100644 ArmPkg/Include/Protocol/ArmScmi.h
> create mode 100644 ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
> create mode 100644 ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
> create mode 100644 ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h
> create mode 100644 ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.c
> create mode 100644 ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
> create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c
> create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.h
> create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
prev parent reply other threads:[~2018-04-23 17:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 16:11 [PATCH v3 00/16] Update GOP Girish Pathak
2018-03-20 16:11 ` [PATCH v3 01/16] ArmPlatformPkg: Rectify line endings of LcdHwNullLib Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:11 ` [PATCH v3 02/16] ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:11 ` [PATCH v3 03/16] ArmPlatformPkg: Tidy Lcd code: Coding standard Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro Girish Pathak
2018-03-21 12:26 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl Girish Pathak
2018-03-21 12:26 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP Girish Pathak
2018-03-21 12:26 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 09/16] ArmPlatformPkg: Redefine LcdPlatformGetTimings function Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 10/16] ArmPlatformPkg: Add PCD to select pixel format Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 11/16] ArmPlatformPkg: PCD to swap red/blue format for HDLCD Girish Pathak
2018-03-21 12:53 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 12/16] ArmPlatformPkg: Additional display modes Girish Pathak
2018-03-21 12:54 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build Girish Pathak
2018-03-21 12:54 ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver Girish Pathak
2018-03-21 12:54 ` Evan Lloyd
2018-04-23 11:07 ` Leif Lindholm
2018-03-20 16:12 ` [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation Girish Pathak
2018-03-21 12:54 ` Evan Lloyd
2018-04-23 11:11 ` Leif Lindholm
2018-03-20 16:12 ` [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol Girish Pathak
2018-03-21 12:54 ` Evan Lloyd
2018-04-23 11:31 ` Leif Lindholm
2018-04-23 16:06 ` Girish Pathak
2018-04-23 16:22 ` Leif Lindholm
2018-04-23 16:49 ` Girish Pathak
2018-04-23 17:11 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423171148.nfe5ntsm2paown67@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox