From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22d; helo=mail-wr0-x22d.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22d.google.com (mail-wr0-x22d.google.com [IPv6:2a00:1450:400c:c0c::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 643DB22839319 for ; Mon, 23 Apr 2018 10:11:52 -0700 (PDT) Received: by mail-wr0-x22d.google.com with SMTP id p5-v6so15545423wre.12 for ; Mon, 23 Apr 2018 10:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z59gCbbhOu3/BWIxwevHyshsXz6K7wl2G/9FGTp+u5w=; b=fu1lSdQzNLklg0o228/02TgsAxHDi9t+VAt+h2URCQxKGAO7uSakfmTjxE8lmYmXp6 dq288qamHsxp2dIUy3RTS8VBEIHEACBB1r/7LjsKiQvfPkVrmYwprW+YSbOxKaisPp7d rmnhWyug6bxWPXNvy+qh6TsudutRt/LatyRYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z59gCbbhOu3/BWIxwevHyshsXz6K7wl2G/9FGTp+u5w=; b=nlp8mxcuHr66j058oPC+VxwjNtgUy/TomZnxpJF3XRrhCqdUR3TQc/INeCZV2dm0u/ aosbMtt0HZ4dViKaKf/pseip23gAyjz/j4fvEulQJN5xRJAnsXdJQzYkUUEdUz+H11Up ZuHnF0mn8ZYuJ8fE2ezcp7yi2iR/bw9pEWyFITGjAU5v3Hx1heOlIEVZOBRRi+HXtZK9 gU5Vt4rqyRV4T0wHIFxsTHGuqVX5kCh9YfEydZN9dULc7jZTQbS+BYOfsqLrNEzsF83l 2E6VKkAJtCH0FdfeEjmvHTRHRnMTzNNGlFxrGjTzf6Sk/lOAZzTIUmHms0cAlHwJOLMw BONA== X-Gm-Message-State: ALQs6tAVNSj/FTJ+1BlfmtC/vXNm+574kM2iSWS6FGyKjdni4jbZZP6a Y7/miuAqYwQqW/yYkN6nlchHRA== X-Google-Smtp-Source: AIpwx48IMfYnU6FF7n827ktPBTJqeUj3tvwsLKo0NQ93JmbPuXOksbnVuGE5ILzRpZRD4XiskCLn3Q== X-Received: by 2002:adf:acae:: with SMTP id o43-v6mr9802061wrc.132.1524503510974; Mon, 23 Apr 2018 10:11:50 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k82sm6716773wmf.17.2018.04.23.10.11.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 10:11:50 -0700 (PDT) Date: Mon, 23 Apr 2018 18:11:48 +0100 From: Leif Lindholm To: Girish Pathak Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180423171148.nfe5ntsm2paown67@bivouac.eciton.net> References: <20180320161212.79120-1-girish.pathak@arm.com> MIME-Version: 1.0 In-Reply-To: <20180320161212.79120-1-girish.pathak@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 00/16] Update GOP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 17:11:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 20, 2018 at 04:11:56PM +0000, Girish Pathak wrote: > This patch series addresses comments on the patch v2 > (https://lists.01.org/pipermail/edk2-devel/2017-December/019389.html) > reworking of the Graphics Output Protocol code in ArmPlatformPkg. > It also contains updates for the new SCMI protocol. > > Corresponding edk2-platforms changes will follow shortly. > For the series: Reviewed-by: Leif Lindholm Pushed as ee4dc24f57..4f2494cf53. Apologies for the delay in getting this through. / Leif > Code is available for examination at: > https://github.com/girishpathak/edk2/tree/201_gop_v3 > > Girish Pathak (16): > ArmPlatformPkg: Rectify line endings of LcdHwNullLib > ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib > ArmPlatformPkg: Tidy Lcd code: Coding standard > ArmPlatformPkg: Tidy Lcd code: Updated comments > ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS > ArmPlatformPkg: PL111Lcd: Replace magic number with macro > ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl > ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP > ArmPlatformPkg: Redefine LcdPlatformGetTimings function > ArmPlatformPkg: Add PCD to select pixel format > ArmPlatformPkg: PCD to swap red/blue format for HDLCD > ArmPlatformPkg: Additional display modes > ArmPlatformPkg: Reserving framebuffer at build > ArmPlatformPkg: New DP500/DP550/DP650 GOP driver > ArmPkg: MTL Library interface and Null library implementation > ArmPkg: Introduce SCMI protocol > > ArmPkg/ArmPkg.dec | 16 +- > ArmPkg/ArmPkg.dsc | 6 +- > ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h | 46 ++ > ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h | 84 ++++ > ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 53 +++ > ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h | 55 +++ > ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 262 +++++++++++ > ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 318 ++++++++++++++ > ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 418 ++++++++++++++++++ > ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 138 ++++++ > ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h | 41 ++ > ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c | 457 ++++++++++++++++++++ > ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 174 ++++++++ > ArmPkg/Include/Library/ArmMtlLib.h | 137 ++++++ > ArmPkg/Include/Protocol/ArmScmi.h | 27 ++ > ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 174 ++++++++ > ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 218 ++++++++++ > ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h | 265 ++++++++++++ > ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.c | 108 +++++ > ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf | 26 ++ > ArmPlatformPkg/ArmPlatformPkg.dec | 21 +- > ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 197 +++++---- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 10 +- > ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 177 ++++++-- > ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 409 ++++++++++++++++++ > ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.h | 243 +++++++++++ > ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 43 ++ > ArmPlatformPkg/Library/HdLcd/HdLcd.c | 174 ++++---- > ArmPlatformPkg/Library/HdLcd/HdLcd.h | 23 +- > ArmPlatformPkg/Library/HdLcd/HdLcd.inf | 4 +- > ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.c | 150 +++---- > ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c | 243 +++++++---- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 125 ++++-- > 34 files changed, 4413 insertions(+), 433 deletions(-) > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiBaseProtocolPrivate.h > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/Scmi.c > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c > create mode 100644 ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h > create mode 100644 ArmPkg/Include/Library/ArmMtlLib.h > create mode 100644 ArmPkg/Include/Protocol/ArmScmi.h > create mode 100644 ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h > create mode 100644 ArmPkg/Include/Protocol/ArmScmiClockProtocol.h > create mode 100644 ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > create mode 100644 ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.c > create mode 100644 ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf > create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c > create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.h > create mode 100644 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >