public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Pete Batard <pete@akeo.ie>
To: edk2-devel@lists.01.org
Cc: liming.gao@intel.com
Subject: [PATCH 0/1] BaseTools/Conf: Add /Gw optimisation option for VS2017 IA32 and X64
Date: Tue, 24 Apr 2018 17:10:10 +0100	[thread overview]
Message-ID: <20180424161011.2320-1-pete@akeo.ie> (raw)

It looks like we forgot to carry over the /Gw optimisation option when adding
VS2017 support for IA32 and X64, whereas it is present in VS2015 and earlier.

Binaries without /Gw can be almost twice as large as when the option is used:
https://docs.microsoft.com/en-gb/cpp/build/reference/gw-optimize-global-data

Note that ARM and ARM64 are unaffected, as they already have the flag.

Pete Batard (1):
  BaseTools/Conf: Add /Gw optimisation option for VS2017 IA32 and X64

 BaseTools/Conf/tools_def.template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.17.0.windows.1



             reply	other threads:[~2018-04-24 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 16:10 Pete Batard [this message]
2018-04-24 16:10 ` [PATCH 1/1] BaseTools/Conf: Add /Gw optimisation option for VS2017 IA32 and X64 Pete Batard
2018-04-25  2:16   ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424161011.2320-1-pete@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox