From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::230; helo=mail-wm0-x230.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED0632041B269 for ; Tue, 24 Apr 2018 09:10:29 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id t67so2114100wmt.0 for ; Tue, 24 Apr 2018 09:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=4jZDxKeIfaCK+nfogz47lckndcdi2kwmuyv7h2+TIZk=; b=d22isqqiJHpOmYKbDnL0fKxWzz7WK+hzSnK1c/OiSfHewHwjROp4DcE+q6cQv6nQk7 XWWSJlK2T+QZmwKZ+ZJ72UY16sF+fO0Q3eQxhTz4GfcuSqClq7BaRYiUR9vKQUJPqjvn U7Y5BK5qM6AVuA8onMxl5xr6BjA6QTHyrMWDPmZ/hcBEFtZkafyhqcaxp6LAMy3CSPzF 2tgRljR6ehKjsFQ85cxIuhhjZohvoAMTEW0B/yeCND1EiUZLqe3+ujlykrjJ0D7SFfKC g+hNF4gI7LuUK+R40NfVhFxRPRDyUZd4zB+7JcMyvdiBsViWQoi3F0HLNXU6qFHb22Fi pa9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4jZDxKeIfaCK+nfogz47lckndcdi2kwmuyv7h2+TIZk=; b=nNxyKr3Spd2R10woubD25kVkuM+UuwlmInDJDraXnU14w+sViaU5t3fsyVgInQNNaI NfTtVhullNpsqtVe/fDdzOkaUITwo21TDINOxz98oLqtlET4evrU/Tr6+i+ayK0dv55/ 0fdD5lR/tJIn4eqH69/OPpOkea+iXfCwiBnDgoLG6CmmgbYaBPBEwHCjy0WWWVW1kDEY p4vnVWRXBSYFQucTSg2tC0VNP7uvo8xMqfW7omrftKiKJrMuXTsl9x29SrkEXsAMqZ27 7E9wQQT7YkJezmnwXT3/HeB0M8E49BWTdgNt7COPd7WJoDhjGIaUJpBlHN1jK9hNoFw2 VQhA== X-Gm-Message-State: ALQs6tApkgj3cKTtJGnWGFZglf1YKQQxwmVfMCbjTAs30JpyjBFtcQZl 5lZcgbxw5gb/+jFoUwSjaVmKCDAwZ3Q= X-Google-Smtp-Source: AIpwx4+ntprADz69aj+znl169loakczB2CLoHIPZlwiKwdLJAIwLCqAbxEz/OCEBAdDy5/BGFvzV4A== X-Received: by 10.80.237.6 with SMTP id j6mr24225111eds.143.1524586226868; Tue, 24 Apr 2018 09:10:26 -0700 (PDT) Received: from localhost.localdomain ([84.203.57.109]) by smtp.gmail.com with ESMTPSA id t1sm1644082edq.84.2018.04.24.09.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 09:10:26 -0700 (PDT) From: Pete Batard To: edk2-devel@lists.01.org Cc: liming.gao@intel.com Date: Tue, 24 Apr 2018 17:10:10 +0100 Message-Id: <20180424161011.2320-1-pete@akeo.ie> X-Mailer: git-send-email 2.17.0.windows.1 Subject: [PATCH 0/1] BaseTools/Conf: Add /Gw optimisation option for VS2017 IA32 and X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 16:10:30 -0000 It looks like we forgot to carry over the /Gw optimisation option when adding VS2017 support for IA32 and X64, whereas it is present in VS2015 and earlier. Binaries without /Gw can be almost twice as large as when the option is used: https://docs.microsoft.com/en-gb/cpp/build/reference/gw-optimize-global-data Note that ARM and ARM64 are unaffected, as they already have the flag. Pete Batard (1): BaseTools/Conf: Add /Gw optimisation option for VS2017 IA32 and X64 BaseTools/Conf/tools_def.template | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.0.windows.1