From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D79732035D6B4 for ; Thu, 26 Apr 2018 08:08:35 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id v15-v6so39045320wrm.10 for ; Thu, 26 Apr 2018 08:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lWsu0Jdf6jer+XSRQ3gKWwUk3Xb20fCHaNcuCTTcj2s=; b=VSsdE5dP23S8vYLEGnTAFlC3IG00j/1naDT9P4TqG1L6lSCXOMeJWhqYKtfmnarSqb cI51mSLt38bFxVQwAaKpkuoLwTVMrK7aImWAh3mQDdgwXY62IclBGbJEtYjPZtTS2blE BczwcyPgLajNnxt0uhlH+29PljG85XZJ+tCuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lWsu0Jdf6jer+XSRQ3gKWwUk3Xb20fCHaNcuCTTcj2s=; b=U359tKt2zrs/7GX9wsOKTQ8pKXfGutwVq7wtPJu8hpfsdO1Qy4BAiUDBhvR7jqPeOZ Y5vrgcKH4FQcjdvCIYxl/kaqupIJ+lpvOx6/DFtGRO8MxKpGYtKDw/D3VagRTXxDYHAn VOb1MhHzcFe9uup3CZWIyEkeoEv+xYDaELyqfWiv5j0qVdwy+nzt+AnFCj1CedERcUv7 I/OyF2fKROOihDh4gK45s9Ap1k2NEL4NXqEkmCZ0eGRAKVpoAqFANR+4reLFJihgQMMK 2nXuG3qbi6xS16x+GPvyRKusFAjISNJf22HedZJxULWgV61drAvvu+4ic2M2yQtirquP g3TA== X-Gm-Message-State: ALQs6tBYQQvIEvwq2hGdT6NS/BCvxtU5+PRVZ9dM8j4KMMxcqPGn7xs9 Qg876eQFNJO7LLrBp1CLLVVmXA== X-Google-Smtp-Source: AIpwx49h4z8omOWcDXOF91V/JfS7IZFyboYKDovIHE+WVsLGMpY+JAWfA3HeT1jIZthGFRNbpRPz3g== X-Received: by 2002:adf:9925:: with SMTP id x34-v6mr29494186wrb.29.1524755313894; Thu, 26 Apr 2018 08:08:33 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o138sm7913555wmg.10.2018.04.26.08.08.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 08:08:32 -0700 (PDT) Date: Thu, 26 Apr 2018 16:08:31 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, michael.d.kinney@intel.com, evan.lloyd@arm.com, Nariman Poushin Message-ID: <20180426150831.7xo74s4cpkg62zst@bivouac.eciton.net> References: <20180426130121.154724-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180426130121.154724-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1] Platforms/ARM: Enable acpiview support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 15:08:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Apr 26, 2018 at 02:01:21PM +0100, Sami Mujawar wrote: > Acpiview is a program that allows examination of ACPI table > contents from the UEFI Shell. > > Enable acpiview support as this can help with investigations, > especially at that stage where the tables are not enabling an > OS to boot. I have no objections to this, but I would prefer to see a comment from Arvind, Thomas or Daniil before merging. Adding Nariman to cc as well for good measure :) However, please use --subject-prefix="PATCH edk2-platforms“ in future. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Reviewed-by: Evan Lloyd > --- > The patch can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/254_enable_acpiview_v1 > > Notes: > v1: > - Enable acpiview support in the UEFI shell for ARM platforms. [SAMI] > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 7cb47937329efa1944ec4c156e2be995a755ce6f..0badb24f030a58363e7bee22a7cc1e03040b60aa 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -450,6 +450,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf Although I would probably move this line up a few to improve sorting. Reviewed-by: Leif Lindholm > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >