public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Sami Mujawar <sami.mujawar@arm.com>
To: edk2-devel@lists.01.org
Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>,
	Daniil Egranov <Daniil.Egranov@arm.com>,
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
	ard.biesheuvel@linaro.org, leif.lindholm@linaro.org,
	Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
	nd@arm.com
Subject: [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno
Date: Fri, 27 Apr 2018 15:58:14 +0100	[thread overview]
Message-ID: <20180427145816.118500-2-sami.mujawar@arm.com> (raw)
In-Reply-To: <20180427145816.118500-1-sami.mujawar@arm.com>

The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as <ASL filename>_aml_code. This update can be seen
in the ACPICA git repository at
https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

A corresponding change is required in the ConfigurationManager
and this patch contains the necessary changes to adapt to the
generated iASL compiler output.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
---
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1

Notes:
    v1:
    - Update Configuration Manager to match iASL compiler output.   [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
     },
     // DBG2 Table
     {
@@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code
     },
     // SSDT table describing the PL011 UART
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code
     },
 
     /* PCI MCFG Table
@@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code
     }
   },
 
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




  reply	other threads:[~2018-04-27 14:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 14:58 [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements Sami Mujawar
2018-04-27 14:58 ` Sami Mujawar [this message]
2018-05-09 11:07   ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Leif Lindholm
2018-04-27 14:58 ` [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP Sami Mujawar
2018-04-27 14:58 ` [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update Sami Mujawar
2018-05-09 11:04   ` Leif Lindholm
2018-05-11 13:29     ` Evan Lloyd
2018-05-12 11:25       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427145816.118500-2-sami.mujawar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox