From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1847A20957AF5 for ; Wed, 2 May 2018 08:14:39 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id v60-v6so14433768wrc.7 for ; Wed, 02 May 2018 08:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yaqs71ZWDi+TsxrEWwNMSNfRSXBlKN4wKSgTzzoX6DE=; b=CRiOFXIFB4DOzdbXnPiG8Fx4RhnBMZvd2D1unrDzZi0HHH0nlh91RoE7N0IDu+QtB3 UNDS04tsUlw1aw2oCJcVOkgSVrgZs1dMYaTLgh/6KTJzY/uKBhHE5mVumcGvDVE6alBf Z95nrAzYAzeWbONEhix8KUY9pzhYrm6lpxr3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yaqs71ZWDi+TsxrEWwNMSNfRSXBlKN4wKSgTzzoX6DE=; b=lLX5zs7N3Ly0pugqXNpKuOrMEd4kVsTqIRp3391Wrwxzw/dzxzPdwwt3/ilOZWPUjM K/qHzjiHnwSNvTHTHvKZhMMmjR8Mqhw+cin5ugPawiJvK9d4CG76aw5NNro6sMpLb4CI vCZRbGegA/xzmZ4M8s2by230qwVYScmuSTPC2RrbyTMoaA+twH87oPyF6JHz3TYjvsE9 dJiOwW6w36Q5/Lbrjc5fdZ9u1LDfKgV4G+cbxEc6UxqGYoplJJ+PklWIrEloWwzvxMDZ 0RuQg/lQmabIfGijvAVaRL0uroTMMolspfeVB4GD+n3UCZ3VaJZNUKcBRKr1xQMwt2hZ eoOw== X-Gm-Message-State: ALQs6tBMKkC6TMAOpcMuODuQcgR8E3ppxi92tNShqRLJ4HcQBJpNDeRO tIGaIndnZ8dZGX8J2SCzBsC0aA== X-Google-Smtp-Source: AB8JxZqxMQcwq1BsBNWVOvWkKnaKzjB9Rp5vllfbf838nvxuBNgPeiQHP4NWvjxmMRuABWh6PZy+Jg== X-Received: by 2002:adf:a0b8:: with SMTP id m53-v6mr15442510wrm.269.1525274078004; Wed, 02 May 2018 08:14:38 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 16-v6sm20164887wrt.20.2018.05.02.08.14.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 May 2018 08:14:36 -0700 (PDT) Date: Wed, 2 May 2018 16:14:35 +0100 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20180502151435.46zbhyux5vh45hh2@bivouac.eciton.net> References: <1520515790-29527-1-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1520515790-29527-1-git-send-email-haojian.zhuang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 15:14:40 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 08, 2018 at 09:29:50PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey960 platform. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + > Platform/Hisilicon/HiKey960/HiKey960.fdf | 1 + > Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf | 35 +++++++++ > Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c | 77 ++++++++++++++++++++ > 4 files changed, 114 insertions(+) > > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc > index 36f43956ab40..3da1b8556321 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc > @@ -179,6 +179,7 @@ [Components.common] > # > # GPIO > # > + Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf > ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf > > # > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf b/Platform/Hisilicon/HiKey960/HiKey960.fdf > index 655032a36c53..162dbaaf2646 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.fdf > +++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf > @@ -120,6 +120,7 @@ [FV.FvMain] > # > # GPIO > # > + INF Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf > INF ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf > > # > diff --git a/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf > new file mode 100644 > index 000000000000..a16213f02520 > --- /dev/null > +++ b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf > @@ -0,0 +1,35 @@ > +# > +# Copyright (c) 2018, Linaro. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > + > +[Defines] > + INF_VERSION = 0x00010019 Probably bump this to 0x0001001a by now. > + BASE_NAME = HiKey960GpioDxe > + FILE_GUID = 6aa12592-7e36-4aec-acf8-2ac2fd13815c > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = HiKey960GpioEntryPoint > + > +[Sources] > + HiKey960GpioDxe.c > + > +[Packages] > + EmbeddedPkg/EmbeddedPkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + UefiDriverEntryPoint > + > +[Protocols] > + gPlatformGpioProtocolGuid > + > +[Depex] > + TRUE > diff --git a/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c > new file mode 100644 > index 000000000000..986feceea564 > --- /dev/null > +++ b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c > @@ -0,0 +1,77 @@ > +/** @file > +* > +* Copyright (c) 2018, Linaro. All rights reserved. > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include > + > +#include > + > +GPIO_CONTROLLER gGpioDevice[]= { Missing space before '='. > + { 0xe8a0b000, 0, 8 }, // GPIO0 It would not improve readability to request all of these live-coded values to be replaced by #defines, but barring that, could you add a comment header before the definition?: // { base address, gpio index, gpio count } > + { 0xe8a0c000, 8, 8 }, // GPIO1 > + { 0xe8a0d000, 16, 8 }, // GPIO2 > + { 0xe8a0e000, 24, 8 }, // GPIO3 > + { 0xe8a0f000, 32, 8 }, // GPIO4 > + { 0xe8a10000, 40, 8 }, // GPIO5 > + { 0xe8a11000, 48, 8 }, // GPIO6 > + { 0xe8a12000, 56, 8 }, // GPIO7 > + { 0xe8a13000, 64, 8 }, // GPIO8 > + { 0xe8a14000, 72, 8 }, // GPIO9 > + { 0xe8a15000, 80, 8 }, // GPIO10 > + { 0xe8a16000, 88, 8 }, // GPIO11 > + { 0xe8a17000, 96, 8 }, // GPIO12 > + { 0xe8a18000, 104, 8 }, // GPIO13 > + { 0xe8a19000, 112, 8 }, // GPIO14 > + { 0xe8a1a000, 120, 8 }, // GPIO15 > + { 0xe8a1b000, 128, 8 }, // GPIO16 > + { 0xe8a1c000, 136, 8 }, // GPIO17 > + { 0xff3b4000, 144, 8 }, // GPIO18 > + { 0xff3b5000, 152, 8 }, // GPIO19 I notice that these: > + { 0xe8a1f000, 160, 8 }, // GPIO20 > + { 0xe8a20000, 168, 8 }, // GPIO21 are out of order, from their base address. Are the names GPIO20/GPIO21 defined in the TRM? > + { 0xfff0b000, 176, 8 }, // GPIO22 > + { 0xfff0c000, 184, 8 }, // GPIO23 > + { 0xfff0d000, 192, 8 }, // GPIO24 > + { 0xfff0e000, 200, 8 }, // GPIO25 > + { 0xfff0f000, 208, 8 }, // GPIO26 > + { 0xfff10000, 216, 8 }, // GPIO27 > + { 0xfff1d000, 224, 8 }, // GPIO28 > +}; > + > +PLATFORM_GPIO_CONTROLLER gPlatformGpioDevice = { > + 232, 29, gGpioDevice And similarly // { global gpio count, gpio controller count, GPIO_CONTROLLER } / Leif > +}; > + > +EFI_STATUS > +EFIAPI > +HiKey960GpioEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + EFI_HANDLE Handle; > + > + // Install the Embedded Platform GPIO Protocol onto a new handle > + Handle = NULL; > + Status = gBS->InstallMultipleProtocolInterfaces( > + &Handle, > + &gPlatformGpioProtocolGuid, &gPlatformGpioDevice, > + NULL > + ); > + if (EFI_ERROR(Status)) { > + Status = EFI_OUT_OF_RESOURCES; > + } > + > + return Status; > +} > -- > 2.7.4 >