Re: [PATCH v2 edk-platforms 3/4] Platform/Hisilicon/HiKey: add gpio platform driver

[Leif Lindholm <leif.lindholm@linaro.org>]

(Reviewing near-identical patches out of order.)

On Thu, Mar 08, 2018 at 09:30:28PM +0800, Haojian Zhuang wrote:
> Add gpio platform driver to enable GPIO in HiKey platform.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf | 36 +++++++++++
>  Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c   | 68 ++++++++++++++++++++
>  2 files changed, 104 insertions(+)
> 
> diff --git a/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf b/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf
> new file mode 100644
> index 000000000000..272ed1c0cea2
> --- /dev/null
> +++ b/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf
> @@ -0,0 +1,36 @@
> +#
> +#  Copyright (c) 2018, Linaro. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +
> +[Defines]
> +  INF_VERSION                    = 0x00010019

0x0001001a?

> +  BASE_NAME                      = HiKeyGpio
> +  FILE_GUID                      = b51a851c-7bf7-463f-b261-cfb158b7f699
> +  MODULE_TYPE                    = DXE_DRIVER
> +  VERSION_STRING                 = 1.0
> +  ENTRY_POINT                    = HiKeyGpioEntryPoint
> +
> +[Sources.common]
> +  HiKeyGpioDxe.c
> +
> +[Packages]
> +  EmbeddedPkg/EmbeddedPkg.dec
> +  MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> +  DebugLib
> +  UefiDriverEntryPoint
> +
> +[Protocols]
> +  gPlatformGpioProtocolGuid
> +
> +[Depex]
> +  TRUE
> diff --git a/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c b/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c
> new file mode 100644
> index 000000000000..543f65d7b12d
> --- /dev/null
> +++ b/Platform/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c
> @@ -0,0 +1,68 @@
> +/** @file
> +*
> +*  Copyright (c) 2018, Linaro. All rights reserved.
> +*
> +*  This program and the accompanying materials
> +*  are licensed and made available under the terms and conditions of the BSD License
> +*  which accompanies this distribution.  The full text of the license may be found at
> +*  http://opensource.org/licenses/bsd-license.php
> +*
> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +*
> +**/
> +
> +#include <Library/UefiBootServicesTableLib.h>
> +
> +#include <Protocol/EmbeddedGpio.h>
> +

Add similar comment as I asked for in 1/4?

> +GPIO_CONTROLLER gGpioDevice[]= {

Missing space before '='.

> +  { 0xf8011000, 0, 8 },    // GPIO0
> +  { 0xf8012000, 8, 8 },    // GPIO1
> +  { 0xf8013000, 16, 8 },   // GPIO2
> +  { 0xf8014000, 24, 8 },   // GPIO3
> +  { 0xf7020000, 32, 8 },   // GPIO4
> +  { 0xf7021000, 40, 8 },   // GPIO5
> +  { 0xf7022000, 48, 8 },   // GPIO6
> +  { 0xf7023000, 56, 8 },   // GPIO7
> +  { 0xf7024000, 64, 8 },   // GPIO8
> +  { 0xf7025000, 72, 8 },   // GPIO9
> +  { 0xf7026000, 80, 8 },   // GPIO10
> +  { 0xf7027000, 88, 8 },   // GPIO11
> +  { 0xf7028000, 96, 8 },   // GPIO12
> +  { 0xf7029000, 104, 8 },  // GPIO13
> +  { 0xf702a000, 112, 8 },  // GPIO14
> +  { 0xf702b000, 120, 8 },  // GPIO15
> +  { 0xf702c000, 128, 8 },  // GPIO16
> +  { 0xf702d000, 136, 8 },  // GPIO17
> +  { 0xf702e000, 144, 8 },  // GPIO18
> +  { 0xf702f000, 152, 8 }   // GPIO19
> +};
> +

Add similar comment as I asked for in 1/4?

> +PLATFORM_GPIO_CONTROLLER gPlatformGpioDevice = {
> +  160, 20, gGpioDevice
> +};
> +
> +EFI_STATUS
> +EFIAPI
> +HiKeyGpioEntryPoint (
> +  IN EFI_HANDLE         ImageHandle,
> +  IN EFI_SYSTEM_TABLE   *SystemTable
> +  )
> +{
> +  EFI_STATUS  Status;
> +  EFI_HANDLE  Handle;
> +
> +  // Install the Embedded Platform GPIO Protocol onto a new handle
> +  Handle = NULL;
> +  Status = gBS->InstallMultipleProtocolInterfaces(
> +                  &Handle,
> +                  &gPlatformGpioProtocolGuid, &gPlatformGpioDevice,
> +                  NULL
> +                 );
> +  if (EFI_ERROR(Status)) {
> +    Status = EFI_OUT_OF_RESOURCES;

So, I didn't comment on this for 1/4, but ...
Why modify Status?

/
    Leif

> +  }
> +
> +  return Status;
> +}
> -- 
> 2.7.4
>