From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::231; helo=mail-wr0-x231.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ACD0520945D8D for ; Wed, 9 May 2018 03:52:21 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id v15-v6so35207855wrm.10 for ; Wed, 09 May 2018 03:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2+d8UTD793staMt5yCc0jZK9zAC9DX6qbeQ7R4crtFI=; b=gQ3xvC2WgeyUAHv0Albpw6AKQ/nQ9OfgsV8m/UvAwJumrUWRzofbekKHPEnzdwmSvk StMOCPxK38dfGqlEi/2w7NU3JJtR+dVIZgYp+CJi/T0hakXJBf6CLjDFu3GCV4eD1H6x FVqUG1g+ckwtd21MkrFke3QOyHXC1nY8u7T3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2+d8UTD793staMt5yCc0jZK9zAC9DX6qbeQ7R4crtFI=; b=O9nMsLaOWKobfiFtVMLK+WheL2aMBOV66NhZ0kzNW+G3P9baDqzaEAm4YytclNHW5c jvQo46q+BK0tpuBd6cEo6ot5LoVsSVvd8oPrnx5gSqg0cnDNoXIJbLqW4Vp/e1zgLisV M6sBaSopEelYV5kF4y/udy4QnzCnNcYT+z9BVR93oEjfoZM+QUiyJLhvmBq0MLYCNitG yceoF4jXd717vQqa2UFGMHljX4hDJbUQVf7P9FUEoO6UMANFrgS8RB1DgCw9j0oTjUle 2mrvALu31bEOCg/AFpBxS7QjJehklBAIXJOrsGJ29Q21Mq6VzyJ4jpc8k9+SbdauNBGi 2l+w== X-Gm-Message-State: ALKqPwfH8m0VRUwPb+q+FsEDVn1b5WItbHwyeQG0g9lDT97k/AMySaoW MMgzH7NXgnQ9fxCoUKQvJqpedQ== X-Google-Smtp-Source: AB8JxZpHF3l6hhBDqxBt55gpCtSS9RJs/oNccsE5o2vrLC7J40fZM6+Ijhotl7lqaKgTecXePK6jXA== X-Received: by 2002:adf:c18a:: with SMTP id x10-v6mr2584785wre.84.1525863139761; Wed, 09 May 2018 03:52:19 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m123-v6sm17631467wma.1.2018.05.09.03.52.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 03:52:18 -0700 (PDT) Date: Wed, 9 May 2018 11:52:17 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, michael.d.kinney@intel.com, evan.lloyd@arm.com Message-ID: <20180509105217.wyd5okxa4wdkyiks@bivouac.eciton.net> References: <20180426130121.154724-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180426130121.154724-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1] Platforms/ARM: Enable acpiview support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 10:52:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 26, 2018 at 02:01:21PM +0100, Sami Mujawar wrote: > Acpiview is a program that allows examination of ACPI table > contents from the UEFI Shell. > > Enable acpiview support as this can help with investigations, > especially at that stage where the tables are not enabling an > OS to boot. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Reviewed-by: Evan Lloyd Please keep reviewed-by to what has been reviewed on the mailing list. (I know Evan has reviewed this and would confirm on list if asked to, so I'll keep it in for patches currently in my queue.) > --- > The patch can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/254_enable_acpiview_v1 > > Notes: > v1: > - Enable acpiview support in the UEFI shell for ARM platforms. [SAMI] > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 7cb47937329efa1944ec4c156e2be995a755ce6f..0badb24f030a58363e7bee22a7cc1e03040b60aa 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -450,6 +450,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf Unless you object to my moving that line 3 rows up before I push: Reviewed-by: Leif Lindholm > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >