From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8A6002096108F for ; Wed, 9 May 2018 04:04:06 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id j4so23951055wme.1 for ; Wed, 09 May 2018 04:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7tQYAtPhBH4Wgw5qomhpnw14Z/8wM7SsHzZpiGyCtYc=; b=SnJQv5HuXcAbLVRJDhO5FrMxXkyipYPBTydw3IZIhuHSfhT9oUOEMVutLeNwMepcVF Gbyjf0A8/b9f3ECtMT0OiF6rg1KpDjZS/OyXZalfkq8+DK5Pa0RvZUiWGBsJO6k+XUzS 49BCGwBI5E+8pcG3R/5EziF9yW/WyYVS/Uicw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7tQYAtPhBH4Wgw5qomhpnw14Z/8wM7SsHzZpiGyCtYc=; b=Z4n47NcGwgnP/pSlDB3z3GmOhn8aeKCyyMbzHfLiJQ4EW+LGk59R8ZQJ7hpiwMF62g zaQ88SPaP8FLcJphRvsVJiCwg3lObx4LxkRy8gsP4sd5CeWFQjJ96ASMQC01qFKLa8ZN gUN2zlvynFdVtKqivzSYU3vGyZpnaXYqQouQIrWZnqlKdN8fXwanj86eGYsxPom5vGBN ymV8vlmFCaRR8tinsi/ULcRj4xn6K8aaB+PbRJJCaAp3e3imsXvhccLEiTtGk+sLtRch dsSXbv8OBEv/5+2cHDacCVcp0kZonhnM/yHMZ5zWZJErSjxOruiP5kS5qHhag3cEXPwR Lddg== X-Gm-Message-State: ALKqPwdTaH6R6Qka1aGrORuO5/8T23/DdLDyTRoiQ5jIq3tHwytVTIwK OOhCHQFmCnWmeRAKVEVEDHi4Mg== X-Google-Smtp-Source: AB8JxZrMu2VkRZeZj1Vb6MkF78l1XrpEdSErp+xTYX356DGLirJnHP/DH1+G1eebd7RWsNwnmJlWZg== X-Received: by 10.28.206.14 with SMTP id e14mr4974296wmg.87.1525863845044; Wed, 09 May 2018 04:04:05 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w31-v6sm66436030wrb.93.2018.05.09.04.04.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 04:04:04 -0700 (PDT) Date: Wed, 9 May 2018 12:04:02 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180509110402.hpgfwluhooxs5eve@bivouac.eciton.net> References: <20180427145816.118500-1-sami.mujawar@arm.com> <20180427145816.118500-4-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180427145816.118500-4-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 11:04:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Apr 27, 2018 at 03:58:16PM +0100, Sami Mujawar wrote: > The ACPICA iASL compiler has been enhanced to support the > generation of an AML hex file which is required by the > Dynamic Tables Framework. The patch for this enhancement > has been integrated in the ACPICA repository. Therefore > the Prerequisites section in the Readme has been updated > accordingly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Reviewed-by: Evan Lloyd > --- > The changes can be seen at > https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1 > > Notes: > v1: > - Update ACPICA iAsl compiler usage guidelines. [SAMI] > > Readme.md | 21 +++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/Readme.md b/Readme.md > index b72efca18e8ab5de17cab06f0a1a0725991256d4..2300fa6be9f83525e8c0ee21800751d9067b02e0 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -87,9 +87,9 @@ contains the Dynamic Tables Framework. > ### ACPICA iASL compiler > The RAW table generator, used to process the DSDT/SSDT files depends on > the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing > -the hex AML code. The current implementation of the iASL compiler does not > -support generation of a C header file suitable for including from a C source > -file. > +the hex AML code. The "-tc" option of the iASL compiler has been enhanced to > +support generation of an AML hex file (C header) with a unique symbol name > +so that it is suitable for inclusion from a C source file. > > Related Links > -------------- > @@ -135,16 +135,19 @@ or > > Prerequisites > ------------- > -ACPICA iASL compiler with support for generating a C header file. > +ACPICA iASL compiler with the enhanced "-tc" option to support generation of > +AML hex (C header) files with unique symbol names. > > -A patch ***'Modify hex AML C header file generation'***, to enable > -this support has been submitted to the ACPICA source repository. > - > +A patch ***'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'***, > +to enable this support has been integrated to the ACPICA source repository. Linux distributions tend to use dates to refer to what particular point a version is based on, since snapshot updates are frequently necessary. In this case, that is 16 March 2018 - please mention that as well in the message. > + > + > +Ensure that the iASL compiler used for building *Dynamic Tables Framework* > +has this feature enabled. > > Documentation > ------------- > -A description document is in preparation, and should be available in the > -near future. > +[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables – Sami Mujawar (Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf) Add a description? I.e.: "Presentation from UEFI Plugfest Seattle 2018"? > > Miscellaneous > ------------- > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >