Re: [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Apr 27, 2018 at 03:58:14PM +0100, Sami Mujawar wrote:
> The iASL compiler's -tc option has been updated to generate
> output that is suitable for including from a C file. The iASL
> compiler uniquely names the C array containing the processed
> table data as <ASL filename>_aml_code. This update can be seen
> in the ACPICA git repository at
> https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

For both 1-2/3, please add a date here, like in the Readme.md.
No further comments on this set.

/
    Leif

> A corresponding change is required in the ConfigurationManager
> and this patch contains the necessary changes to adapt to the
> generated iASL compiler output.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
> ---
> The changes can be seen at
> https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1
> 
> Notes:
>     v1:
>     - Update Configuration Manager to match iASL compiler output.   [SAMI]
> 
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644
> --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> @@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
>      },
>      // DBG2 Table
>      {
> @@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code
>      },
>      // SSDT table describing the PL011 UART
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code
>      },
>  
>      /* PCI MCFG Table
> @@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code
>      }
>    },
>  
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
>