From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22f; helo=mail-wm0-x22f.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3926320348605 for ; Wed, 9 May 2018 04:07:13 -0700 (PDT) Received: by mail-wm0-x22f.google.com with SMTP id a8so23913492wmg.5 for ; Wed, 09 May 2018 04:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KnyVb9FLJ2S2ijRv0p7sV11GJFpZWtOivMzTc3dsm3o=; b=VW+Wu0ytEMP7ArtR6LXKXcOa5lzWfRc/ftHzIFpLhnf3eBOIbsOy2ghZIXp40JKw+R C8wBeih7f1a8GLV9rgCadRUthjTbVR+KJmEmXPZ+yXbX8GSsLqsRVeciD2DvOrU3bixs Fgm416LuN9pEElx8rep7T+Svov1PD0Efo5toQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KnyVb9FLJ2S2ijRv0p7sV11GJFpZWtOivMzTc3dsm3o=; b=jyCZ50DJZHSDYIomt3Po6oBJ5KDRqJaasuPwemDw0wcV6VpH/DsyndrbNBhU6DcTnV tHBUN+2+wYVyhiaqsZLmSpFoQP4dIy64wKH3D6vn6QWJTYcs88O6THa9eV8Dg14YysYk bxglQ5h7EKOkUY8M1TD36SwyyiaVKD9zERvnobXqNtlp4Mgrd8L8xxHtLbs9HEnHX+Cd BS35tWFtVTTOL5PWFoeRgslFsYkZxjaABrUzp7zdNDEGIjIUE/6UfWYC9ZWctHSUhlSK 7WsYifc/RXbjAJIt9n36mXNAxZgpEWqEHmQBXiCCNCWvzGgIBCN/1sxGQ0hSXm6JD8cN +wyQ== X-Gm-Message-State: ALKqPwedKpMX9BjeewjMtjaK6j1+SbjxVtpgrg2iclc8ay/qxFjVlxLM BcI09vhANuwtICnh6jxzzZ8eFg== X-Google-Smtp-Source: AB8JxZq6/NfkfhxJlSHS1NxRSShiKztGecGQHwImAACVpxorudtN13EJbhZwqqJdm1B9TFpBUDjp4g== X-Received: by 10.28.40.86 with SMTP id o83mr6128135wmo.3.1525864032425; Wed, 09 May 2018 04:07:12 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z18-v6sm38133294wrc.36.2018.05.09.04.07.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 04:07:11 -0700 (PDT) Date: Wed, 9 May 2018 12:07:09 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180509110709.k4t3wrovxx7uy32h@bivouac.eciton.net> References: <20180427145816.118500-1-sami.mujawar@arm.com> <20180427145816.118500-2-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180427145816.118500-2-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 11:07:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 27, 2018 at 03:58:14PM +0100, Sami Mujawar wrote: > The iASL compiler's -tc option has been updated to generate > output that is suitable for including from a C file. The iASL > compiler uniquely names the C array containing the processed > table data as _aml_code. This update can be seen > in the ACPICA git repository at > https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37 For both 1-2/3, please add a date here, like in the Readme.md. No further comments on this set. / Leif > A corresponding change is required in the ConfigurationManager > and this patch contains the necessary changes to adapt to the > generated iASL compiler output. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Reviewed-by: Evan Lloyd > --- > The changes can be seen at > https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1 > > Notes: > v1: > - Update Configuration Manager to match iASL compiler output. [SAMI] > > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644 > --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > @@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = { > { > EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, > CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT), > - (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode > + (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code > }, > // DBG2 Table > { > @@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = { > { > EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, > CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), > - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode > + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code > }, > // SSDT table describing the PL011 UART > { > EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, > CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), > - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode > + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code > }, > > /* PCI MCFG Table > @@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = { > { > EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, > CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), > - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode > + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code > } > }, > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >