From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9612220965DDC for ; Wed, 9 May 2018 09:24:28 -0700 (PDT) Received: by mail-wm0-x231.google.com with SMTP id w194so25751517wmf.2 for ; Wed, 09 May 2018 09:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hdmt8NngBoowaTgu2mrkIE7eBvZmpgH2bkaKSNk4TXg=; b=UBEfreT4Xp8DCfb+3zz/Yey0ONLNO2VaVvRyHCcXRWCCGBdtmQB6lg2hESngiloFDe V928YUovdSmz9tz12ffNC+I/uIJpQgU5HrqX6thZqt5LxKJY4yS0hL8T4rW831QuDJSt 76AEwD2D8yAoTCwJdSFfKDyoou4F3wNa9Ny9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hdmt8NngBoowaTgu2mrkIE7eBvZmpgH2bkaKSNk4TXg=; b=S+t7v54m9Kjl0OklfraRUOx0JCV0Ks87ih9oQxgdotCZ0an8nJ2FYTw/Czn3n5O32/ TO8NgOaIOix/G40ThHduYPo7c2uZ5psTLzH7jxDr6GvkpWymgPf6cUOw+C8w83io4Qux rb0edQmUh6Xqa00dd6bGQbY4PnPgTyLhYNXg66bpgw2U347lEJ+sDfxuoO/zsAPu37lC Rp/SAKC8UpKixUvZWz8st+TXXnNJf9PKUEb2+aNiGFieF6Xb5uBmKoPsX9GQDVUGYOSQ XoeKxY1cAKAK4BIPFIIP1mH8NCDlWigwmr0xsoXo3ADiTYgyUKG0kOBU0KlOZYHr0HW8 4fGQ== X-Gm-Message-State: ALKqPwdgJ9GCVhjDm1LoyfFPlEioOsAXuwT80AnxnMJCvTVaB9lovbHe Rz8T4HvBdYs6+YS+58ZMARjMJQ== X-Google-Smtp-Source: AB8JxZrRrHie+olKc6adqFLse00hyHQRoxcHjyP4jJkCXDeV7762EUOcSmOuVmtZl8LHeMCXEI5t/Q== X-Received: by 10.28.72.196 with SMTP id v187mr6023528wma.115.1525883066892; Wed, 09 May 2018 09:24:26 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j8-v6sm46273613wra.58.2018.05.09.09.24.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 09:24:25 -0700 (PDT) Date: Wed, 9 May 2018 17:24:23 +0100 From: Leif Lindholm To: Alexei Fedorov Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Ard.Biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Evan.Lloyd@arm.com, Sami.Mujawar@arm.com Message-ID: <20180509162423.qt45fahwk7skl6hk@bivouac.eciton.net> References: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> MIME-Version: 1.0 In-Reply-To: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 16:24:29 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alexei, On Thu, May 03, 2018 at 10:24:21AM +0100, Alexei Fedorov wrote: > From: Alexei Fedorov > > UEFI build fails for ArmVExpress-FVP-AArch64 when using > "-D ARM_FVP_RUN_NORFLASH" build option, which prevents > EDK2_SKIP_PEICORE macro from being defined in > ArmVExpress-FVP-AArch64.dsc: > > !ifndef ARM_FVP_RUN_NORFLASH > DEFINE EDK2_SKIP_PEICORE=1 > !endif > > When EDK2_SKIP_PEICORE macro is not defined, build fails with > errors 1001: > Module type [PEI_CORE] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] > and > Module type [PEIM] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] > > This patch fixes the above build errors by adding > MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > sections of ArmVExpress.dsc.inc. Yes, this fixes a bug, however I am still unable to build FVP with -D ARM_FVP_RUN_NORFLASH: --- In file included from /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c:22:0: /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: fatal error: VExpressMotherBoard.h: No such file or directory #include ^ compilation terminated. --- Presumably this has been broken since commit 8ad58788b5c did not carry across -I$(WORKSPACE)/ArmPlatformPkg/ArmVExpressPkg/Include in GCC:*_*_AARCH64_PLATFORM_FLAGS when migrating ArmVExpressPkg from edk2. Can you confirm whether you can reproduce this? If so, the following stanza resolves the issue for me: diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf index 2287756cf8..ed9720e8ce 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf @@ -22,6 +22,7 @@ [Defines] [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + Platform/ARM/VExpressPkg/ArmVExpressPkg.dec EmbeddedPkg/EmbeddedPkg.dec ArmPkg/ArmPkg.dec ArmPlatformPkg/ArmPlatformPkg.dec Best Regards, Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Reviewed-by: Evan Lloyd > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/237_add_peireportstatuscodelib_v1 > > Notes: > v1: > - Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexei] > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506cca75224f4bc41e3ae 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >