From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 690B1207E5413 for ; Wed, 9 May 2018 09:33:59 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id f6so25921328wmc.4 for ; Wed, 09 May 2018 09:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3KabdcOHPtgiixFckz0lWPJRq5/RYvWiFI20rvNGR3k=; b=OWPVfSzbNKP3RLHqYxahlaTGrp5g6HC75qcvCTw4pOyCShaMCVOOVmxT6Ei3FYSDKz Zj7zZ9sBLEox0TC241Pmu9PLQ6zK1nZoYpSPxpD4LZbXp1zs6RriNH2b2Wx3gbKJ2Hel iiHcZU+pVR4Q+L3UiStSa4BWLOEBCfQl5UUK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3KabdcOHPtgiixFckz0lWPJRq5/RYvWiFI20rvNGR3k=; b=Qk+r0H2ufUoQDu79rGOzpCGQATnZPRasSX4kOvD8rJbtpuLkOcF+BUTf+v6QUVQcUR TkKk96ZMpWZ6/qQ9+HGwK53/1qAlrZy4lYVE56aOAT1RShi7MG8uuDMVO0AN1Pfzxmrm tjqqEV026X5919HSzfU/1GaBFPJFbooCfreiHft1dg2IaAHUmk7NnijciVV+q3nEn/av DLG7Nh7Gfsf7JtbQ6lHcpMsLuqIV3w+WQvCaNWpOPkVn/i87TUNTkA8iOmwyQVNNhGDG txcC9uI8tEwZ0QezF8eDIZAgL+JWz202a220zZio11c+6XUsa6E7XGIvEki7P8TweFzI wmgg== X-Gm-Message-State: ALKqPweLq86yWoKO1+SmPlOfDwIKNU6EizERl5Jg7s70ODE4OtoGEoev /oy4j+dKtbJBtJSBssF65hxYjA== X-Google-Smtp-Source: AB8JxZo8nuziyvQdbkEV3g1mPdXs7Sv8jYL8A4TFRcn+zk5G93fdnVywn/Q24729WA65a8Wl0r/C6A== X-Received: by 2002:a1c:8444:: with SMTP id g65-v6mr6986491wmd.114.1525883637454; Wed, 09 May 2018 09:33:57 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g75sm19378909wmd.15.2018.05.09.09.33.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 09:33:56 -0700 (PDT) Date: Wed, 9 May 2018 17:33:55 +0100 From: Leif Lindholm To: Alexei Fedorov Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , Ard.Biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Evan.Lloyd@arm.com Message-ID: <20180509163355.jnrxxdeoxutsjlny@bivouac.eciton.net> References: <1525278402-43588-1-git-send-email-alexei.fedorov@arm.com> MIME-Version: 1.0 In-Reply-To: <1525278402-43588-1-git-send-email-alexei.fedorov@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 16:33:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 02, 2018 at 05:26:42PM +0100, Alexei Fedorov wrote: > From: Alexei Fedorov > > ARM Generic Interrupt Controller is incorrectly named as > "ARM General Interrupt Controller" in ArmJuno.dsc, > ArmVExpress-CTA15-A7.dsc and ArmVExpress-FVP-AArch64.dsc. > > This patch corrects the comment by changing "General" to "Generic". > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Reviewed-by: Evan Lloyd Like I asked Sami today, please let Evan send his own r-b on the list in future. I'll keep it in here for now. For the patch: Reviewed-by: Leif Lindholm > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/261_correct_gic_naming_v1 This is much appreciated - however, please link to the actual version you send out. That one contains a "Change-ID" tag that was not present in this email, and it also lacks the Evan Reviewed-by (also it messes with the commit hash). Thanks for the cleanup - pushed as 5cfda16b1a. > > Notes: > v1: > - Change ARM "General" Interrupt Controller to "Generic" [Alexei] > > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 4 ++-- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 5ec563cefbcd9d97614dc9944bfaeb3822c4634d..8d6dd0207db5f16d7fcc0c5fd59fea38498f3034 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -150,7 +150,7 @@ [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|40000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C010000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C02F000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index ef737670126db980abcc0e0ac9b84321bfa97584..6405d955f15a87c8d7b379f8c05b43f3e0830c54 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2018, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -156,7 +156,7 @@ [PcdsFixedAtBuild.common] > > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2C001000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x2C002000 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 600bffb66703305f4a6baec930cd044998744c24..ca19fd65265a531e8c0869460aa9b6358b70bf91 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -147,7 +147,7 @@ [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x1C050000 > > # > - # ARM General Interrupt Controller > + # ARM Generic Interrupt Controller > # > gArmTokenSpaceGuid.PcdGicDistributorBase|0x2f000000 > gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x2f100000 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >