From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D28220965DDE for ; Wed, 9 May 2018 09:40:28 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id y15-v6so24496697wrg.11 for ; Wed, 09 May 2018 09:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EEomIDxK3v+n6VF/gNbikDxy/0rtBNua/9EQP9KyH74=; b=Ia7JNQvKZmXpbTYfNvaJcYreoSVsMdAZPAFzYmetbM+vAI2xERWXJYVT/Gw3eMdrG/ l6EvHPUkEF2FIV5da6trdBgoYjmmtS3xx9skqGFOlOW5rXBQgx94X83jL9scJShPcksd qENydosm00XLJOefOxqigQIa5CuuN0VaIWuAk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EEomIDxK3v+n6VF/gNbikDxy/0rtBNua/9EQP9KyH74=; b=hAwCyfxtjzO0Dme5XJIPETT8yUgHmqcIhOK3bGlKXml5SqUzwUSUmnssX7waqU1w68 aqVlZMwvpJb0sBIjQAbY5caedK7nxvsXkcI8dJECJeXGpv+dehLf6K5mdZasxyqVooji 2gOXMLHivW70uXtalIyt5Pav6aLwZrwNy3G5pz0DEyKq1HMwr6wttwMWFC9+sNFAP9AO 2pJkenxKcjEH3HxQJwshmcA4PSZ5UUBgByunwwiRJe4Zg7FoFJo3peVrR3Mm9YTCrkYz Esk6Bu34NqeOf/o9ZMylJiR8oneTh7ifGnZ9AbfE4wfwo2v+idvDCRMeI/Orju5wGEEx lnhQ== X-Gm-Message-State: ALQs6tBrb+MrQisqRL09n3GfypLSWdEfAeIhTf+vgupbY28yspfBsn6N R/IRgT5NZdpxEOioKSa708CQiw== X-Google-Smtp-Source: AB8JxZoM1NpYl3SdiZEQYxrkEYR2VuNiJa2DSR3Wkfxgoy5ntdO6cnRHTKEylZO4reBjXAb5GjEGeg== X-Received: by 2002:adf:e943:: with SMTP id m3-v6mr34668291wrn.185.1525884027151; Wed, 09 May 2018 09:40:27 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g28-v6sm11687200wmc.38.2018.05.09.09.40.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 09:40:26 -0700 (PDT) Date: Wed, 9 May 2018 17:40:24 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, jsd@semihalf.com, jinghua@marvell.com, jaz@semihalf.com Message-ID: <20180509164024.lxkesp2gptq7xh7n@bivouac.eciton.net> References: <1525873871-799-1-git-send-email-mw@semihalf.com> <1525873871-799-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1525873871-799-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms PATCH v2 2/4] Marvell/Armada70x0Db: Use more generic output fd file name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 16:40:29 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 09, 2018 at 03:51:09PM +0200, Marcin Wojtas wrote: > Unification of output file name will ease handling build scripts > (e.g. for CI purpose) when multiple board support will be added. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas I have no objections to this patch, but please repost it with the set that adds multiple board support. When you do, you can add Reviewed-by: Leif Lindholm > --- > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf b/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf > index befb107..e165d90 100644 > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf > @@ -24,7 +24,7 @@ > # > ################################################################################ > > -[FD.Armada70x0Db_EFI] > +[FD.Armada_EFI] > BaseAddress = 0x00000000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. > Size = 0x00400000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device > ErasePolarity = 1 > -- > 2.7.4 >