From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::230; helo=mail-wr0-x230.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C3E220348631 for ; Wed, 9 May 2018 14:13:41 -0700 (PDT) Received: by mail-wr0-x230.google.com with SMTP id i14-v6so33698110wre.2 for ; Wed, 09 May 2018 14:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ln1VWRRZZ/WAytnTLw8I1TtNj2nUkEaJ2EGUiEN6k9Y=; b=ibA6HF+Dmkm/9O+mCAsdTKWOyFoqS2P65oTHDAWdljTgT526GXvm+ipFhf+A+KiHu7 0ZH+1c2fIwWSgnVAj/Po46P1QEfe/S0hzmcrwMiseXyT1wwBA099fVdFeJkaipDmMCTC nHTJW/lkopEc+cIFgoD5QtWx2/8WcDq6VbmZc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ln1VWRRZZ/WAytnTLw8I1TtNj2nUkEaJ2EGUiEN6k9Y=; b=ATRUKj6W4PeGVN4Po3D5eV00X0TfsZRz9tp8TcjnV6/RzqcAqcXHbyDi7m2/YcgyFy pDj4tE97pLQHc3lRexvjyLEa7bu9VV8qV3zs+ugnpnKF5WDFHojSUjIifrXiDlRyk9Ba hoA2bGnOIhp9MExClFeNuTQVpadkkjtaVi1/fniXzBJ+WvYsORdIC00M9dROAInOtkzK A8h6mktCWtyYFqbcz0t2f4DnAgA8uUEgbph0jrMvslGuxLhV3ng4lFvCO6uD9YNCT8Y9 Y7G/GsGs/CJDvkEYhkqKn3z2yHW09eRJLLd73TBH4TKy7bSllW1svktBy0sxaZGy55Xn n64g== X-Gm-Message-State: ALQs6tDYOlKwH1dm5HR4aozNsnNSVJC/vRRLb0JsKdGAJ42nJUo9YC1P MoxpEEsXlPT9D7KPPoxkgAcSlg== X-Google-Smtp-Source: AB8JxZqAzswbv/3Qp9qBH9ZnkpOp4MHARqOkDtAoAcKSUBabcv0Bu6b+98VhrNVo8MnZPqYnnQamaA== X-Received: by 2002:adf:b083:: with SMTP id i3-v6mr35737598wra.52.1525900419447; Wed, 09 May 2018 14:13:39 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c50-v6sm39604404wrc.11.2018.05.09.14.13.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 14:13:38 -0700 (PDT) Date: Wed, 9 May 2018 22:13:36 +0100 From: Leif Lindholm To: Alexei Fedorov Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Abraham , "Ard.Biesheuvel@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Evan Lloyd , Sami Mujawar Message-ID: <20180509211336.jnwec2hpnnkh2bu3@bivouac.eciton.net> References: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> <20180509162423.qt45fahwk7skl6hk@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 21:13:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 09, 2018 at 04:58:52PM +0000, Alexei Fedorov wrote: > Hi Leif, > > You wrote: > > Yes, this fixes a bug, however I am still unable to build FVP with > > -D ARM_FVP_RUN_NORFLASH: > > --- > > In file included from > > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c:22:0: > > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > > fatal error: VExpressMotherBoard.h: No such file or directory > > #include > > ^ > > compilation terminated. > > --- > > > > Presumably this has been broken since commit 8ad58788b5c did not carry across > > -I$(WORKSPACE)/ArmPlatformPkg/ArmVExpressPkg/Include in > > GCC:*_*_AARCH64_PLATFORM_FLAGS when migrating ArmVExpressPkg from edk2. > > > > Can you confirm whether you can reproduce this?" > > > > Yes, & it was fixed it by adding > > -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include > > in GCC:*_*_AARCH64_PLATFORM_FLAGS of ArmVExpress-FVP-AArch64.dsc: > > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include/Platform/RTSM I still prefer the .dec way over ading more explicit platform-specific -I flags. Could you fold that into the patch and update the subject line to something like "fix FVP build with -D ARM_FVP_RUN_NORFLASH"? Regards, Leif > > Regards. > > Alexei > > ________________________________ > From: Leif Lindholm > Sent: 09 May 2018 17:24:23 > To: Alexei Fedorov > Cc: edk2-devel@lists.01.org; Arvind Chauhan; Daniil Egranov; Thomas Abraham; Ard.Biesheuvel@linaro.org; Matteo Carlini; Stephanie Hughes-Fitt; nd; Evan Lloyd; Sami Mujawar > Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib > > Hi Alexei, > > On Thu, May 03, 2018 at 10:24:21AM +0100, Alexei Fedorov wrote: > > From: Alexei Fedorov > > > > UEFI build fails for ArmVExpress-FVP-AArch64 when using > > "-D ARM_FVP_RUN_NORFLASH" build option, which prevents > > EDK2_SKIP_PEICORE macro from being defined in > > ArmVExpress-FVP-AArch64.dsc: > > > > !ifndef ARM_FVP_RUN_NORFLASH > > DEFINE EDK2_SKIP_PEICORE=1 > > !endif > > > > When EDK2_SKIP_PEICORE macro is not defined, build fails with > > errors 1001: > > Module type [PEI_CORE] is not supported by library instance > > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > > consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] > > and > > Module type [PEIM] is not supported by library instance > > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > > consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] > > > > This patch fixes the above build errors by adding > > MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > > sections of ArmVExpress.dsc.inc. > > Yes, this fixes a bug, however I am still unable to build FVP with > -D ARM_FVP_RUN_NORFLASH: > --- > In file included from > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c:22:0: > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > #include > ^ > compilation terminated. > --- > > Presumably this has been broken since commit 8ad58788b5c did not carry across > -I$(WORKSPACE)/ArmPlatformPkg/ArmVExpressPkg/Include in > GCC:*_*_AARCH64_PLATFORM_FLAGS when migrating ArmVExpressPkg from edk2. > > Can you confirm whether you can reproduce this? > > If so, the following stanza resolves the issue for me: > diff --git > a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > index 2287756cf8..ed9720e8ce 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > @@ -22,6 +22,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > > Best Regards, > > Leif > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Alexei Fedorov > > Reviewed-by: Evan Lloyd > > --- > > All the changes can be reviewed at: > > https://github.com/AlexeiFedorov/edk2-platforms/tree/237_add_peireportstatuscodelib_v1 > > > > Notes: > > v1: > > - Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexei] > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506cca75224f4bc41e3ae 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > > @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > >