* [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa
@ 2018-05-18 6:15 Dandan Bi
2018-05-21 7:15 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Dandan Bi @ 2018-05-18 6:15 UTC (permalink / raw)
To: edk2-devel; +Cc: Marvin Haeuser, Liming Gao
In commit b6d5def2faf56334128ea2f056356d7e3852831e
when adding 'OUT' decorator for the parameter in AddUnicodeString(),
it delete the function name by mistake. This patch is to fix this
issue.
CC: Marvin Haeuser <Marvin.Haeuser@outlook.com>
CC: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
index 61a32e29760..443a7391721 100644
--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
@@ -863,10 +863,11 @@ LookupUnicodeString2 (
member of SupportedLanguages.
**/
EFI_STATUS
EFIAPI
+AddUnicodeString (
IN CONST CHAR8 *Language,
IN CONST CHAR8 *SupportedLanguages,
IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
IN CONST CHAR16 *UnicodeString
)
--
2.14.3.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa
2018-05-18 6:15 [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa Dandan Bi
@ 2018-05-21 7:15 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-05-21 7:15 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Dandan Bi
>Sent: Friday, May 18, 2018 2:15 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [edk2] [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by
>commit b6d5def2fa
>
>In commit b6d5def2faf56334128ea2f056356d7e3852831e
>when adding 'OUT' decorator for the parameter in AddUnicodeString(),
>it delete the function name by mistake. This patch is to fix this
>issue.
>
>CC: Marvin Haeuser <Marvin.Haeuser@outlook.com>
>CC: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>---
> IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>index 61a32e29760..443a7391721 100644
>--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
>@@ -863,10 +863,11 @@ LookupUnicodeString2 (
> member of SupportedLanguages.
>
> **/
> EFI_STATUS
> EFIAPI
>+AddUnicodeString (
> IN CONST CHAR8 *Language,
> IN CONST CHAR8 *SupportedLanguages,
> IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable,
> IN CONST CHAR16 *UnicodeString
> )
>--
>2.14.3.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-21 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-18 6:15 [patch] IntelFrameworkPkg/UefiLib: Fix build fail caused by commit b6d5def2fa Dandan Bi
2018-05-21 7:15 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox