public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH edk2-platforms v4 1/6] Platform/Hisilicon/HiKey960: add gpio platform driver
Date: Mon, 21 May 2018 10:26:05 +0100	[thread overview]
Message-ID: <20180521092605.jsgorbgkrlzb2nmm@bivouac.eciton.net> (raw)
In-Reply-To: <1526272473-25565-2-git-send-email-haojian.zhuang@linaro.org>

On Mon, May 14, 2018 at 12:34:28PM +0800, Haojian Zhuang wrote:
> Add gpio platform driver to enable GPIO in HiKey960 platform.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Platform/Hisilicon/HiKey960/HiKey960.dsc           |  1 +
>  Platform/Hisilicon/HiKey960/HiKey960.fdf           |  1 +
>  .../HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c     | 83 ++++++++++++++++++++++
>  .../HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf   | 35 +++++++++
>  4 files changed, 120 insertions(+)
>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c
>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf
> 
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> index 36f43956ab40..3da1b8556321 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> @@ -179,6 +179,7 @@ [Components.common]
>    #
>    # GPIO
>    #
> +  Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf
>    ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
>  
>    #
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf b/Platform/Hisilicon/HiKey960/HiKey960.fdf
> index 655032a36c53..162dbaaf2646 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.fdf
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf
> @@ -120,6 +120,7 @@ [FV.FvMain]
>    #
>    # GPIO
>    #
> +  INF Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf
>    INF ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
>  
>    #
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c
> new file mode 100644
> index 000000000000..b196455072cc
> --- /dev/null
> +++ b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.c
> @@ -0,0 +1,83 @@
> +/** @file
> +*
> +*  Copyright (c) 2018, Linaro. All rights reserved.
> +*
> +*  This program and the accompanying materials
> +*  are licensed and made available under the terms and conditions of the BSD License
> +*  which accompanies this distribution.  The full text of the license may be found at
> +*  http://opensource.org/licenses/bsd-license.php
> +*
> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +*
> +**/
> +
> +#include <Library/UefiBootServicesTableLib.h>
> +
> +#include <Protocol/EmbeddedGpio.h>
> +
> +GPIO_CONTROLLER gGpioDevice[] = {
> +  //
> +  // { base address, gpio index, gpio count }
> +  //
> +  { 0xe8a0b000, 0, 8 },    // GPIO0
> +  { 0xe8a0c000, 8, 8 },    // GPIO1
> +  { 0xe8a0d000, 16, 8 },   // GPIO2
> +  { 0xe8a0e000, 24, 8 },   // GPIO3
> +  { 0xe8a0f000, 32, 8 },   // GPIO4
> +  { 0xe8a10000, 40, 8 },   // GPIO5
> +  { 0xe8a11000, 48, 8 },   // GPIO6
> +  { 0xe8a12000, 56, 8 },   // GPIO7
> +  { 0xe8a13000, 64, 8 },   // GPIO8
> +  { 0xe8a14000, 72, 8 },   // GPIO9
> +  { 0xe8a15000, 80, 8 },   // GPIO10
> +  { 0xe8a16000, 88, 8 },   // GPIO11
> +  { 0xe8a17000, 96, 8 },   // GPIO12
> +  { 0xe8a18000, 104, 8 },  // GPIO13
> +  { 0xe8a19000, 112, 8 },  // GPIO14
> +  { 0xe8a1a000, 120, 8 },  // GPIO15
> +  { 0xe8a1b000, 128, 8 },  // GPIO16
> +  { 0xe8a1c000, 136, 8 },  // GPIO17
> +  { 0xff3b4000, 144, 8 },  // GPIO18
> +  { 0xff3b5000, 152, 8 },  // GPIO19
> +  { 0xe8a1f000, 160, 8 },  // GPIO20
> +  { 0xe8a20000, 168, 8 },  // GPIO21
> +  { 0xfff0b000, 176, 8 },  // GPIO22
> +  { 0xfff0c000, 184, 8 },  // GPIO23
> +  { 0xfff0d000, 192, 8 },  // GPIO24
> +  { 0xfff0e000, 200, 8 },  // GPIO25
> +  { 0xfff0f000, 208, 8 },  // GPIO26
> +  { 0xfff10000, 216, 8 },  // GPIO27
> +  { 0xfff1d000, 224, 8 },  // GPIO28
> +};
> +
> +PLATFORM_GPIO_CONTROLLER gPlatformGpioDevice = {
> +  //
> +  // { global gpio count, gpio controller count, GPIO_CONTROLLER }
> +  //
> +  232, 29, gGpioDevice
> +};
> +
> +EFI_STATUS
> +EFIAPI
> +HiKey960GpioEntryPoint (
> +  IN EFI_HANDLE         ImageHandle,
> +  IN EFI_SYSTEM_TABLE   *SystemTable
> +  )
> +{
> +  EFI_STATUS  Status;
> +  EFI_HANDLE  Handle;
> +
> +  // Install the Embedded Platform GPIO Protocol onto a new handle
> +  Handle = NULL;
> +  Status = gBS->InstallMultipleProtocolInterfaces(
> +                  &Handle,
> +                  &gPlatformGpioProtocolGuid, &gPlatformGpioDevice,
> +                  NULL
> +                 );
> +  if (EFI_ERROR(Status)) {
> +    Status = EFI_OUT_OF_RESOURCES;
> +  }
> +
> +  return Status;
> +}
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf
> new file mode 100644
> index 000000000000..5ea3747321d8
> --- /dev/null
> +++ b/Platform/Hisilicon/HiKey960/HiKey960GpioDxe/HiKey960GpioDxe.inf
> @@ -0,0 +1,35 @@
> +#
> +#  Copyright (c) 2018, Linaro. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +
> +[Defines]
> +  INF_VERSION                    = 0x0001001a
> +  BASE_NAME                      = HiKey960GpioDxe
> +  FILE_GUID                      = 6aa12592-7e36-4aec-acf8-2ac2fd13815c
> +  MODULE_TYPE                    = DXE_DRIVER
> +  VERSION_STRING                 = 1.0
> +  ENTRY_POINT                    = HiKey960GpioEntryPoint
> +
> +[Sources]
> +  HiKey960GpioDxe.c
> +
> +[Packages]
> +  EmbeddedPkg/EmbeddedPkg.dec
> +  MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> +  UefiDriverEntryPoint
> +
> +[Protocols]
> +  gPlatformGpioProtocolGuid
> +
> +[Depex]
> +  TRUE
> -- 
> 2.7.4
> 


  reply	other threads:[~2018-05-21  9:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  4:34 [PATCH v4 0/6] enable virtual keyboard Haojian Zhuang
2018-05-14  4:34 ` [PATCH edk2-platforms v4 1/6] Platform/Hisilicon/HiKey960: add gpio platform driver Haojian Zhuang
2018-05-21  9:26   ` Leif Lindholm [this message]
2018-05-14  4:34 ` [PATCH edk2-platforms v4 2/6] Platform/HiKey960: do basic initialization Haojian Zhuang
2018-05-21  9:41   ` Leif Lindholm
2018-05-23  7:14     ` Haojian Zhuang
2018-05-14  4:34 ` [PATCH edk2-platforms v4 3/6] Platform/HiKey960: enable virtual keyboard Haojian Zhuang
2018-05-21  9:48   ` Leif Lindholm
2018-05-14  4:34 ` [PATCH edk2-platforms v4 4/6] Platform/Hisilicon/HiKey: add gpio platform driver Haojian Zhuang
2018-05-21  9:48   ` Leif Lindholm
2018-05-14  4:34 ` [PATCH edk2-platforms v4 5/6] Platform/HiKey: do basic initialization on hikey Haojian Zhuang
2018-05-21  9:54   ` Leif Lindholm
2018-05-14  4:34 ` [PATCH edk2-platforms v4 6/6] Platform/HiKey: enable virtual keyboard Haojian Zhuang
2018-05-21  9:55   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521092605.jsgorbgkrlzb2nmm@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox