public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 0/2] Fix ECC reported issues.
@ 2018-05-22  5:51 Eric Dong
  2018-05-22  5:51 ` [Patch 1/2] MdePkg/TcgStorage*.h: Fixed " Eric Dong
  2018-05-22  5:51 ` [Patch 2/2] MdePkg/TcgStorage*.h: Fix " Eric Dong
  0 siblings, 2 replies; 5+ messages in thread
From: Eric Dong @ 2018-05-22  5:51 UTC (permalink / raw)
  To: edk2-devel

Fix ECC reported issues.

Eric Dong (2):
  MdePkg/TcgStorage*.h: Fixed ECC reported issues.
  MdePkg/TcgStorage*.h: Fix ECC reported issues.

 MdePkg/Include/IndustryStandard/TcgStorageCore.h           |  2 +-
 MdePkg/Include/IndustryStandard/TcgStorageOpal.h           |  8 ++++----
 SecurityPkg/Include/Library/TcgStorageCoreLib.h            |  2 +-
 SecurityPkg/Include/Library/TcgStorageOpalLib.h            | 12 ++++++------
 SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c |  2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.15.0.windows.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Patch 1/2] MdePkg/TcgStorage*.h: Fixed ECC reported issues.
  2018-05-22  5:51 [Patch 0/2] Fix ECC reported issues Eric Dong
@ 2018-05-22  5:51 ` Eric Dong
  2018-05-23  1:25   ` Bi, Dandan
  2018-05-22  5:51 ` [Patch 2/2] MdePkg/TcgStorage*.h: Fix " Eric Dong
  1 sibling, 1 reply; 5+ messages in thread
From: Eric Dong @ 2018-05-22  5:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Dandan Bi

Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 MdePkg/Include/IndustryStandard/TcgStorageCore.h | 2 +-
 MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/TcgStorageCore.h b/MdePkg/Include/IndustryStandard/TcgStorageCore.h
index ab121722ba..0b2852e92d 100644
--- a/MdePkg/Include/IndustryStandard/TcgStorageCore.h
+++ b/MdePkg/Include/IndustryStandard/TcgStorageCore.h
@@ -2,7 +2,7 @@
   TCG defined values and structures.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/MdePkg/Include/IndustryStandard/TcgStorageOpal.h b/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
index ace7309cee..e8f313c3d3 100644
--- a/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
+++ b/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
@@ -2,16 +2,16 @@
   Opal Specification defined values and structures.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
 
   Storage Work Group Storage Security Subsystem Class: Pyrite, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
 
   Storage Work Group Storage Security Subsystem Class: Opal, Version 2.01 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
+  https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
 
   TCG Storage Security Subsystem Class: Opalite Version 1.00 Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/)
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
-- 
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Patch 2/2] MdePkg/TcgStorage*.h: Fix ECC reported issues.
  2018-05-22  5:51 [Patch 0/2] Fix ECC reported issues Eric Dong
  2018-05-22  5:51 ` [Patch 1/2] MdePkg/TcgStorage*.h: Fixed " Eric Dong
@ 2018-05-22  5:51 ` Eric Dong
  2018-05-23  1:31   ` Bi, Dandan
  1 sibling, 1 reply; 5+ messages in thread
From: Eric Dong @ 2018-05-22  5:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Dandan Bi

Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 SecurityPkg/Include/Library/TcgStorageCoreLib.h            |  2 +-
 SecurityPkg/Include/Library/TcgStorageOpalLib.h            | 12 ++++++------
 SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
index 97f9a9f968..6e178c968f 100644
--- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
@@ -2,7 +2,7 @@
   Public API for the Tcg Core library to perform the lowest level TCG Data encoding.
   
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/SecurityPkg/Include/Library/TcgStorageOpalLib.h b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
index b3092eb5cd..33f8fee183 100644
--- a/SecurityPkg/Include/Library/TcgStorageOpalLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
@@ -2,22 +2,22 @@
   Public API for Opal Core library.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
 
   Storage Work Group Storage Security Subsystem Class: Pyrite, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
 
   Storage Work Group Storage Security Subsystem Class: Opal, Version 2.01 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
+  https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
 
   TCG Storage Security Subsystem Class: Opalite Version 1.00 Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
 
   TCG Storage Feature Set: Block SID Authentication, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
+  https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
 
   TCG Storage Opal SSC Feature Set: PSID Version 1.00, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
+  https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
index a8bf3a9160..ca8e7fbbdf 100644
--- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
+++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
@@ -981,7 +981,7 @@ OpalUtilGetActiveDataRemovalMechanism (
 /**
   Calculate the estimated time.
 
-  @param[in]      IsMinite               Whether the input time value is minute type or second type.
+  @param[in]      IsMinute               Whether the input time value is minute type or second type.
   @param[in]      Time                   The input time value.
 
 **/
-- 
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Patch 1/2] MdePkg/TcgStorage*.h: Fixed ECC reported issues.
  2018-05-22  5:51 ` [Patch 1/2] MdePkg/TcgStorage*.h: Fixed " Eric Dong
@ 2018-05-23  1:25   ` Bi, Dandan
  0 siblings, 0 replies; 5+ messages in thread
From: Bi, Dandan @ 2018-05-23  1:25 UTC (permalink / raw)
  To: Dong, Eric, edk2-devel@lists.01.org

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Dong, Eric 
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [Patch 1/2] MdePkg/TcgStorage*.h: Fixed ECC reported issues.

Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 MdePkg/Include/IndustryStandard/TcgStorageCore.h | 2 +-  MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/TcgStorageCore.h b/MdePkg/Include/IndustryStandard/TcgStorageCore.h
index ab121722ba..0b2852e92d 100644
--- a/MdePkg/Include/IndustryStandard/TcgStorageCore.h
+++ b/MdePkg/Include/IndustryStandard/TcgStorageCore.h
@@ -2,7 +2,7 @@
   TCG defined values and structures.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
+  
+ https://trustedcomputinggroup.org/tcg-storage-architecture-core-specif
+ ication/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/MdePkg/Include/IndustryStandard/TcgStorageOpal.h b/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
index ace7309cee..e8f313c3d3 100644
--- a/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
+++ b/MdePkg/Include/IndustryStandard/TcgStorageOpal.h
@@ -2,16 +2,16 @@
   Opal Specification defined values and structures.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
+  
+ https://trustedcomputinggroup.org/tcg-storage-architecture-core-specif
+ ication/
 
   Storage Work Group Storage Security Subsystem Class: Pyrite, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
+  
+ https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class
+ -pyrite/
 
   Storage Work Group Storage Security Subsystem Class: Opal, Version 2.01 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
+  
+ https://trustedcomputinggroup.org/storage-work-group-storage-security-
+ subsystem-class-opal/
 
   TCG Storage Security Subsystem Class: Opalite Version 1.00 Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/)
+  
+ https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class
+ -opalite/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
--
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Patch 2/2] MdePkg/TcgStorage*.h: Fix ECC reported issues.
  2018-05-22  5:51 ` [Patch 2/2] MdePkg/TcgStorage*.h: Fix " Eric Dong
@ 2018-05-23  1:31   ` Bi, Dandan
  0 siblings, 0 replies; 5+ messages in thread
From: Bi, Dandan @ 2018-05-23  1:31 UTC (permalink / raw)
  To: Dong, Eric, edk2-devel@lists.01.org

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

And these changes are in SecurityPkg not MdePkg.
Please update the package name in the subject of the patch before commit.


Thanks,
Dandan

-----Original Message-----
From: Dong, Eric 
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [Patch 2/2] MdePkg/TcgStorage*.h: Fix ECC reported issues.

Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 SecurityPkg/Include/Library/TcgStorageCoreLib.h            |  2 +-
 SecurityPkg/Include/Library/TcgStorageOpalLib.h            | 12 ++++++------
 SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
index 97f9a9f968..6e178c968f 100644
--- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
@@ -2,7 +2,7 @@
   Public API for the Tcg Core library to perform the lowest level TCG Data encoding.
   
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/SecurityPkg/Include/Library/TcgStorageOpalLib.h b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
index b3092eb5cd..33f8fee183 100644
--- a/SecurityPkg/Include/Library/TcgStorageOpalLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
@@ -2,22 +2,22 @@
   Public API for Opal Core library.
 
   (TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
+  https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
 
   Storage Work Group Storage Security Subsystem Class: Pyrite, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
 
   Storage Work Group Storage Security Subsystem Class: Opal, Version 2.01 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
+  https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
 
   TCG Storage Security Subsystem Class: Opalite Version 1.00 Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
+  https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
 
   TCG Storage Feature Set: Block SID Authentication, Version 1.00 Final, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
+  https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
 
   TCG Storage Opal SSC Feature Set: PSID Version 1.00, Revision 1.00,
-  @https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
+  https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
 
   Check http://trustedcomputinggroup.org for latest specification updates.
 
diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
index a8bf3a9160..ca8e7fbbdf 100644
--- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
+++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
@@ -981,7 +981,7 @@ OpalUtilGetActiveDataRemovalMechanism (
 /**
   Calculate the estimated time.
 
-  @param[in]      IsMinite               Whether the input time value is minute type or second type.
+  @param[in]      IsMinute               Whether the input time value is minute type or second type.
   @param[in]      Time                   The input time value.
 
 **/
-- 
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-23  1:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-22  5:51 [Patch 0/2] Fix ECC reported issues Eric Dong
2018-05-22  5:51 ` [Patch 1/2] MdePkg/TcgStorage*.h: Fixed " Eric Dong
2018-05-23  1:25   ` Bi, Dandan
2018-05-22  5:51 ` [Patch 2/2] MdePkg/TcgStorage*.h: Fix " Eric Dong
2018-05-23  1:31   ` Bi, Dandan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox