From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2868721B02845 for ; Tue, 22 May 2018 04:20:33 -0700 (PDT) Received: by mail-wr0-x242.google.com with SMTP id w18-v6so15710984wrn.6 for ; Tue, 22 May 2018 04:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GzMjgiLbEtN+H1nHVO9Wc9KnFHg3HSA/lR6NQkwfCFE=; b=WJUt6FwGO/EQGd9/rpZxbB65xA9OSq3/yJErGrdrEtd8kfC345oz2cJEn5lG0jewY8 EHqZHZ/rLORSG/Abhw6A5k6kWIcCV2GJidjvXrtsrrS/WhXGm7vIeWXH4V+UUmi3hUw6 PhQBXOuBQxJR8yckUFi6uto1nA850JWPHCGuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GzMjgiLbEtN+H1nHVO9Wc9KnFHg3HSA/lR6NQkwfCFE=; b=Kcg5bzrvme9zucBroWxMMVH6mvQyJg7DQ9YZKgQ941mTAwrXMGfD7uD/525hHTymkk o5Ov8yAxOj1ybrR8agN+SfoRvvSLaTY9i2M8gm3AvFPU9QtNNbWV7AlMMNXIdMOOlLs9 uvAMzJufC7JgPusU1zFgzdf6rT/Qa0L7wHgwUa7KCWqtuLLmK4TKh9u6xK0kyXePWizt vesLA/5mVktl0ugMhzsH1S5TPAtlU/zivZd+cGkYiAEZIr6XwqxLGTGiNNNih7Cjb9pS /y6JhmwjR/LYIHw7UmGVkBbCbiPa/vKXqaKphO7BKCP2gpsVdcgGledLNcwWKbNmjo6d paMw== X-Gm-Message-State: ALKqPweTDInMJZ2WWnhcoRWaMyLpk3vIcQjEqjpj62ixDf814dvSCG4K soyi2B+L4OQBdh/uU/4kg0QBFg== X-Google-Smtp-Source: AB8JxZpGrCbS/YHLNpzdF/T4KnFnESQQjBHzI8joW8SPJjom+ijxdrFAnnv4JkVeD2+fMdOfLvhRYA== X-Received: by 2002:adf:eb12:: with SMTP id s18-v6mr2962000wrn.174.1526988031891; Tue, 22 May 2018 04:20:31 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y7-v6sm7104176wrh.86.2018.05.22.04.20.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 04:20:30 -0700 (PDT) Date: Tue, 22 May 2018 12:20:29 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , Grzegorz Jaszczyk Message-ID: <20180522112029.bdkckm5jrtu4wteh@bivouac.eciton.net> References: <1525873871-799-1-git-send-email-mw@semihalf.com> <1525873871-799-5-git-send-email-mw@semihalf.com> <20180509164916.eau7cgjf674ll6mn@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 11:20:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 21, 2018 at 12:54:01PM +0200, Marcin Wojtas wrote: > Hi Leif, > > > 2018-05-09 18:49 GMT+02:00 Leif Lindholm : > > > A couple of minor style comments. > > > > If you don't disagree, I can fix that up before pushing and you can > > have Reviewed-by: Leif Lindholm for 1,3-4. > > > > > Yes, I would appreciate that. 1,3-4/4 pushed as 5cfda16b1a..a310c6b5e1. / Leif