From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5FBBF2034863B for ; Tue, 22 May 2018 04:34:50 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id a67-v6so30794783wmf.3 for ; Tue, 22 May 2018 04:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6pMULjalaXUywZom+fNrRj3TInsEP0MLhDKvikgf+yA=; b=HSrPFRcnAcIFR0kJAi8WmfWDjxN2yCMInVXIHOi6W3jnMkrOdruotbpaDfGNZWZYcM b9HYyVJMXy5I2rKq+hH9joCZohnb8xMPvav+7HlQ2YCFo1ej1N4pesUXXX5dgSTznA1a Hs+VtgE0B+oPzT8b8BcHcVrM7tuvAl6ubPbmE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6pMULjalaXUywZom+fNrRj3TInsEP0MLhDKvikgf+yA=; b=SROhPRGpP1O806zqYT+n9q0PVsG8f0o/YfKCYDTTPtyau4KQ2T6CEWJf7E2GWzAWTH Qwy3jpwUYxLH+QXUTB2fxJ7Ewd+MFDHIlOq//MzAYj+pN+oX4T5Nyt3GAhg8bMuXUJon sNWSjoyQNerD9/oF01z6mnAWKuqV5IA28n2FHy3uhLV4a/TNL98nZ7zudxBqedTAleZ4 oECDBHD1rE+Ny3IasUpWMpdMT3jKqd7i0TqexVNU2VWdv/Elu16hs6Gh19L/QmdKfOPp s8Q7OJSVScGjLDXMUUDtbqCPom1Wmcl3HZ2861NPhBKJmylBkrNNtpvwi/ChRfMJH4pf 0Nbw== X-Gm-Message-State: ALKqPwcYvoT6lifWa7WV8Tn5CN1wOTqXwZbUwCUq+u+Fo/onkk6arGAS IwS6ZY8NfcGWe1ysZElKBFoFhg== X-Google-Smtp-Source: AB8JxZpmauFqiKKluIF26bQWjhNLkBlOSNVfZV/UKkARXzLuCDmfsJ0qTTrrnqV45vGuu1+24OImHA== X-Received: by 2002:a1c:7f0a:: with SMTP id a10-v6mr991610wmd.97.1526988888687; Tue, 22 May 2018 04:34:48 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 89-v6sm5145638wri.37.2018.05.22.04.34.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 04:34:47 -0700 (PDT) Date: Tue, 22 May 2018 12:34:46 +0100 From: Leif Lindholm To: AlexeiFedorov Cc: edk2-devel@lists.01.org, Arvind Chauhan , Thomas Panakamattam Abraham , Ard.Biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Evan.Lloyd@arm.com, Sami.Mujawar@arm.com Message-ID: <20180522113445.hgjqyf2ai7xur5eh@bivouac.eciton.net> References: <1526915366-13028-1-git-send-email-Alexei.Fedorov@arm.com> MIME-Version: 1.0 In-Reply-To: <1526915366-13028-1-git-send-email-Alexei.Fedorov@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D ARM_FVP_RUN_NORFLASH" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 11:34:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 21, 2018 at 04:09:26PM +0100, AlexeiFedorov wrote: > From: Alexei Fedorov > > UEFI build fails for ArmVExpress-FVP-AArch64 when using > "-D ARM_FVP_RUN_NORFLASH" build option, which prevents > EDK2_SKIP_PEICORE macro from being defined in > ArmVExpress-FVP-AArch64.dsc: > > !ifndef ARM_FVP_RUN_NORFLASH > DEFINE EDK2_SKIP_PEICORE=1 > !endif > > When EDK2_SKIP_PEICORE macro is not defined, build fails with > errors 1001: > Module type [PEI_CORE] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] > Module type [PEIM] is not supported by library instance > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf] > consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] > and > ../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:10: > fatal error: VExpressMotherBoard.h: No such file or directory > > This patch fixes the above build errors by adding > MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > sections of ArmVExpress.dsc.inc and > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > in [Packages] section of ArmVExpressLibSec.inf > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov Reviewed-by: Leif Lindholm Pushed as f17e3a1649. Thanks! > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platforms/tree/237_fix_fvp_build_v1 > > Notes: > v1: > Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexei] > Add ArmVExpressPkg.dec in ArmVExpressLibSec.inf [Alexei] > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506cca75224f4bc41e3ae 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > index 2287756cf8c5f988ac1fe85485f242407ebffa67..ec29d99835401b65f45ff494df4a0955a1618af1 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf > @@ -1,5 +1,5 @@ > #/* @file > -# Copyright (c) 2011-2012, ARM Limited. All rights reserved. > +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -22,6 +22,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >