From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B776E209603F6 for ; Tue, 22 May 2018 08:04:15 -0700 (PDT) Received: by mail-wr0-x242.google.com with SMTP id u12-v6so1786192wrn.8 for ; Tue, 22 May 2018 08:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ipbjJL1eTe2f6G9OkXipTDU2ryvjpmIrUIhDYitAI80=; b=hGDNN+OTWqt2UT9pwbbz/88l21SjPkyZnKXxDss2yWBOHhwBzWfoelXDJVh9CEFkWk CXk2ecsDf3n/IMRQirKUji5VVrR5uJED9H/Tz9aljFhBNjZQ6YLlQ1hfoubaeAtOwVe9 MtvCfjtSQtRbdyoAyMYZhFJwOiHTvTIGtqLfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ipbjJL1eTe2f6G9OkXipTDU2ryvjpmIrUIhDYitAI80=; b=EvY9vr4szqcqft+wQWUIT40/TMjJmoQuo/wgu7tVLBHrpvOUZPWf+HTqj7qVOE3E2j hc0yrTJpHCgSCoybVt6s8ZGlYZmBxqmx8q+0Gv8ORCdB8GEjOB0CRmhVZIxUiIS92Bz7 0YrRc5+ACt1NDvfz3HLVu23zK6WfxdcjWOA0TbT18YoPAZDm1sH66nU7VZTakZRkHR7q eRvqeefBwaJaD7dON7Xy3GtFcTJ/jEZpusMmv/aGSk08idJz+I7p5Rd6p5C6q2wmL9ee OXf5RwB+eytSDLYA25UA1URgDb7bPtwZoBiezWsagl3vpjTvleU3a5NIdSgzI09himph ch6A== X-Gm-Message-State: ALKqPwdcdw32B+GmgjNsa6x7VPTpEskthKBHn1LrV0IFXPRyK4xqoDcZ s/Ly2EtdIPKUnX6PTtVXeVxG1w== X-Google-Smtp-Source: AB8JxZqFJZYNmmKO94vbTaFFBCwcl+c3sYmguPP3AXfEKIz8swYtid7yDJqAWp2/pR7e9dc1uysBww== X-Received: by 2002:adf:f78d:: with SMTP id q13-v6mr10814855wrp.60.1527001454124; Tue, 22 May 2018 08:04:14 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y81-v6sm117924wmd.31.2018.05.22.08.04.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 08:04:12 -0700 (PDT) Date: Tue, 22 May 2018 16:04:11 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180522150411.45avxw4r5akzwfje@bivouac.eciton.net> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> <20180427113748.21663-3-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180427113748.21663-3-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 2/5] Platform/Socionext/DeveloperBox: add SNP driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 15:04:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To save me making a triple-take when I see this commit in the log in future, could you change the subject to say SnpDxe instead of SNP? If so, for the series: Reviewed-by: Leif Lindholm On Fri, Apr 27, 2018 at 01:37:45PM +0200, Ard Biesheuvel wrote: > Even though the builtin NETSEC controller driver implements the Simple > Network Protocol (SNP) directly, other network controllers connected > via PCIe may be supported by a UNDI driver, which require the generic > SnpDxe driver in order to be usable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index cc36c2ed1772..430c3fb06df1 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -633,6 +633,7 @@ [Components.common] > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > + MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > index 2da83850975b..1b8de4c3823a 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > @@ -203,6 +203,7 @@ [FV.FvMain] > INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > + INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > -- > 2.17.0 >