From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::229; helo=mail-wm0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C2F7207E4E08 for ; Wed, 23 May 2018 07:14:55 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id f6-v6so9447815wmc.4 for ; Wed, 23 May 2018 07:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AQfo1d25l5GT30MinW14eghgpvnu6/jTsIYPWYReWB0=; b=dzjCFBgp1Gjk2Ys61q0lXxjboSVlsSXnyR34TJ4wovx/Xl7aZmuJxZzIBMa9KoyQxv Stau/gmCnUvtf7uR4APF6IPkF6Hekg8DXiOIlF28mBHBgm/J3fXPicR6lTHdIQIPgcf2 bx/z2+RGc0TV2JpeNN/wC3kYRLogJfP4kUjOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AQfo1d25l5GT30MinW14eghgpvnu6/jTsIYPWYReWB0=; b=FPIHEJnnUDzWXKGS4y7nkVpg3D729qls77qt3IYcUjRFDnhKD5GCxsVJuJPnc3jJru ToDBaKbytXgTTELmZ/5jNiLmG5vp5M8XZ+T9TLCtAGMeAeYs1Dmj6/JnNOenxHXH5cBN wnnFqPYbfgRgwlDmbT5Rhs0FNLNEfiupZeO2vqAdx47lOus4+QXxchQdspzups3ebJTw ajjIEgEAOUzoSYc0DbR+KH46y9+6NL2MImwa8jUemXzwFDIVvkTX1rsAKMQd4spp/fd3 Rzletn9rxqABCRYyf5MyzoQRUobuKpIibewMEPMiSfjCr9P++qMQ5QzH14dTDzLwcVJx nnqw== X-Gm-Message-State: ALKqPwdKKY/1HFmy1GuDVoGbTP9KBvCqhN8EGAMenirnNp4yW/dP1fIx qlGHMAMBOGTjGaKJTMcdK8BXDwwHdho= X-Google-Smtp-Source: AB8JxZpG8OEqeLgZW67tRUs+gayGWoGAouig93XhBK4fSGrY+Te04AI9ErZtI5YS/B6LgIgDkUZ3Ww== X-Received: by 2002:a1c:8a03:: with SMTP id m3-v6mr3984939wmd.135.1527084893279; Wed, 23 May 2018 07:14:53 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id o12-v6sm27347774wrf.31.2018.05.23.07.14.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:14:52 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, Ard Biesheuvel Date: Wed, 23 May 2018 16:14:43 +0200 Message-Id: <20180523141444.20033-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org> References: <20180523141444.20033-1-ard.biesheuvel@linaro.org> Subject: [PATCH edk2-platforms 3/4] Platform/DeveloperBox: switch to protocol based DevicePathLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 14:14:55 -0000 We already include DevicePathDxe, which exposes a protocol that implements DevicePathLib in a way that can be shared across modules, avoiding the need for multiple copies of UefiDevicePathLib, which is rather heavy weight. However, we are not actually using it, and all DevicePathLib users carry a private copy of UefiDevicePathLib. So wire up all modules except DxeCore and DevicePathDxe itself, which cannot use the protocol for obvious reasons. Also, avoid creating a cyclic dependency between PcdDxe and DevicePathDxe by using PcdLibNull in the latter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc index 1bfe7fcaca01..3decc22e25b1 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -93,7 +93,7 @@ [LibraryClasses.common] UefiLib|MdePkg/Library/UefiLib/UefiLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf @@ -475,6 +475,7 @@ [Components.common] MdeModulePkg/Core/Dxe/DxeMain.inf { NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F } @@ -497,7 +498,12 @@ [Components.common] ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf { + + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf + } + MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf -- 2.17.0