public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH edk2-platforms 4/4] Silicon/Socionext/SynQuacerPciHostBridgeLib: DEPEX on variable protocol
Date: Wed, 23 May 2018 16:14:44 +0200	[thread overview]
Message-ID: <20180523141444.20033-5-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20180523141444.20033-1-ard.biesheuvel@linaro.org>

As discussed on-list [0], dynamic HII PCDs are backed by EFI variables,
but having PcdDxe DEPEXing on gEfiVariableArchProtocolGuid in general
is too restrictive, and so it is up to the platforms themselves to
DEPEX on gEfiVariableArchProtocolGuid in modules that use PCDs that
the platform may declare as dynamic HII. This also applies to the PCD
gSynQuacerTokenSpaceGuid.PcdPlatformSettings on the SynQuacer platform,
which is used by its PciHostBridgeLib implementation. So add the DEPEX
to make this dependency explicit.

[0] https://lists.01.org/pipermail/edk2-devel/2018-April/023700.html

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf
index e475529eaf58..8b8bb5df57d3 100644
--- a/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf
+++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLib.inf
@@ -54,3 +54,8 @@ [FixedPcd]
 [Pcd]
   gSynQuacerTokenSpaceGuid.PcdPcieEnableMask
   gSynQuacerTokenSpaceGuid.PcdPlatformSettings
+
+[Depex]
+  # gSynQuacerTokenSpaceGuid.PcdPlatformSettings may be of the dynamic HII
+  # variety, which are backed by EFI variables
+  gEfiVariableArchProtocolGuid
-- 
2.17.0



  parent reply	other threads:[~2018-05-23 14:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 14:14 [PATCH edk2-platforms 0/4] SynQuacer updates Ard Biesheuvel
2018-05-23 14:14 ` [PATCH edk2-platforms 1/4] Platform/DeveloperBox: add 96boards/Socionext logo Ard Biesheuvel
2018-05-23 14:14 ` [PATCH edk2-platforms 2/4] Platform/DeveloperBox: add PCI serial driver Ard Biesheuvel
2018-05-23 14:14 ` [PATCH edk2-platforms 3/4] Platform/DeveloperBox: switch to protocol based DevicePathLib Ard Biesheuvel
2018-05-23 14:14 ` Ard Biesheuvel [this message]
2018-05-31  7:34 ` [PATCH edk2-platforms 0/4] SynQuacer updates Ard Biesheuvel
2018-05-31  9:04 ` Leif Lindholm
2018-05-31 10:47   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523141444.20033-5-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox