From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7162020D7B244 for ; Wed, 30 May 2018 07:09:05 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id f8-v6so48099723wmc.4 for ; Wed, 30 May 2018 07:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=L1b1pw4zRHkJ+Z07YFWig5GgsXWGPHovxm71vvHkvbc=; b=eDcsYpXtUEKm9QmAmqzNSUAHNOAp3zOus6hNq2Jg4PDy/t1U4UvLHbrmVuteGeHuZc seWI8uOwpYXEL/YnV76EcBhhAOtlvQQ9ysB2xTTWen2s4T7BmgEE9vksAFGfvzc1/N6Q r+jWoKyCyWRv3bkAT+eS07uFRUkp07qHynSdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=L1b1pw4zRHkJ+Z07YFWig5GgsXWGPHovxm71vvHkvbc=; b=X7TldYY1Gz2/9CeNerM3c+zU/cEpYvsfrSxg0NOrBMwTXYKTwtwhQ4gi3agvzw1e6D vlyU9U5MfwTohxuTAHRTvSJGMbmq0tPl1/9XdkEN6jX/bpF/anvuikPqj7NnJ28ROUH2 dMvma8V8UYzwuE0I3lAqU+D2//32U1GEV0mNFUn7PB4FXUjKXtXw1+6z4blRn0RLZwt7 cf596ync0YYTcJM7zthlnyunH9jXlPLpdtMOE1S/5ZP3P3p5vGhgJRwC9RgyHtpAkkOn a6bnKPkuqZ50EvTjuC3cctyYdR5zIAK4uLtOWkLSowtLHBvxkSBw+iarI+kJUnvP5Aeh 6kaw== X-Gm-Message-State: ALKqPwc/VCibNZIJ1GgeptF3c+6TsoM3h5wQsHuAHwBq6ePiL0WsCnPu XYGOFWHBsROtPcC2XPS3Bi7oGg== X-Google-Smtp-Source: ADUXVKLQNTCFUTXnjbJ/n4FzVDH5vdSewyH2XtSYZNhBwP7jTxNugK9eXaxR00Wbmp3mtETMFvGtfA== X-Received: by 2002:a1c:2cc2:: with SMTP id s185-v6mr1519214wms.62.1527689343956; Wed, 30 May 2018 07:09:03 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e7-v6sm34946275wrn.88.2018.05.30.07.09.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 07:09:02 -0700 (PDT) Date: Wed, 30 May 2018 15:09:01 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, evan.lloyd@arm.com Message-ID: <20180530140901.tiadwziibuw66vxd@bivouac.eciton.net> References: <20180518110831.29576-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180518110831.29576-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [staging/dynamictables PATCH v2] Update Readme.md to reflect ACPICA compiler update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 14:09:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, May 18, 2018 at 12:08:31PM +0100, Sami Mujawar wrote: > The ACPICA iASL compiler has been enhanced to support the > generation of an AML hex file which is required by the > Dynamic Tables Framework. The patch for this enhancement > has been integrated in the ACPICA repository. Therefore > the Prerequisites section in the Readme has been updated > accordingly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar Reviewed-by: Leif Lindholm Pushed as 726ccd02b1. > --- > > The changes can be seen at https://github.com/samimujawar/edk2-staging/tree/258_reflect_acpica_compiler_enhancement_v2 > > Notes: > v2: > - Add patch commit date and info about presentation. [LEIF] > - Updated Readme.md to add date for referencing ACPICA patch. > Also annotated the UEFI presentation. [SAMI] > > v1: > - Update ACPICA iAsl compiler usage guidelines. [SAMI] > > Readme.md | 25 +++++++++++++------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/Readme.md b/Readme.md > index b72efca18e8ab5de17cab06f0a1a0725991256d4..6501623503d6ec8ef4840aebc70561d44cf1ca12 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -87,9 +87,9 @@ contains the Dynamic Tables Framework. > ### ACPICA iASL compiler > The RAW table generator, used to process the DSDT/SSDT files depends on > the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing > -the hex AML code. The current implementation of the iASL compiler does not > -support generation of a C header file suitable for including from a C source > -file. > +the hex AML code. The "-tc" option of the iASL compiler has been enhanced to > +support generation of an AML hex file (C header) with a unique symbol name > +so that it is suitable for inclusion from a C source file. > > Related Links > -------------- > @@ -135,16 +135,23 @@ or > > Prerequisites > ------------- > -ACPICA iASL compiler with support for generating a C header file. > +ACPICA iASL compiler with the enhanced "-tc" option to support generation of > +AML hex (C header) files with unique symbol names. > > -A patch ***'Modify hex AML C header file generation'***, to enable > -this support has been submitted to the ACPICA source repository. > - > +A patch *'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'*, dated 16 March 2018 (2018-03-16), > +to enable this support has been integrated to the ACPICA source repository. > + > +Ensure that the iASL compiler used for building *Dynamic Tables Framework* has this feature enabled. > + > +This feature was made available in the *ACPICA Compiler update > +[Version 20180508](https://www.acpica.org/node/156)*, dated 8 May 2018 (2018-05-08). > > Documentation > ------------- > -A description document is in preparation, and should be available in the > -near future. > + > +Refer to the following presentation from *UEFI Plugfest Seattle 2018*: > + > +[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables – Sami Mujawar (Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf) > > Miscellaneous > ------------- > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >