From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48F2A20D7B264 for ; Wed, 30 May 2018 07:49:39 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id r15-v6so20775368wmc.1 for ; Wed, 30 May 2018 07:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=eDO2SU0cwDfpY0pawG6Nnj1eTfwDXcUaqBjZay6Yh2s=; b=WlRXt09qcsd6PQEd1ZQ270cutc0iyowOGp9v0EtO/Y1ZuKVyLajn8HyccueCDtdQYu B+iQb1QNYra1Oym3SVnv89Hv00VH394Dv95i00yt/z+GkJrZSo9V8Brx2uisG3auRqF9 ZwcPLoFuS7ehqlVgIzPVM/YUlRJUtQIc1fwA0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=eDO2SU0cwDfpY0pawG6Nnj1eTfwDXcUaqBjZay6Yh2s=; b=jCh03B/s4a0FxwFaeWCGmjQX48gPsB33MZ/V6ZhTYuDRd5Fw2J5EFTLbk270HN5nXj DUUh6PkCOhW2+YkGe2EOVzMtH/yEMfsUZX0jL8POc4/gNnqdCPVzNjmJ7Sfi9KXQj08M kQT10DtyBsFkieaQcED6PIWhK3jQreT3/kPAQh4R+3uLtsW+/blaoq5ZXH0xdtcUALV5 j6YVdgXwWoiPRQY44WwBw+MpryTYH9QEwTf+L2AfmObIcD32ndD8z+aMOf5vbQNhpx/B qyl8naTlb+MJVaiNfRMRbA3v6eMYZIeW+GpbjbZNX0MAp+0d2Y3AfhBJN/7uFBb0vsTz GpkA== X-Gm-Message-State: ALKqPwdQP368URR/aEocuX+UCkGuSZdvEHRAEFKlEHTul/h4PYL1pkYP OI+drVWlVuHLXzdcVg+gvA+oTQ== X-Google-Smtp-Source: ADUXVKIwxVrzpBd8/JywlM2FzO9R7OVWCz5iZB1BAe+j0fp5B/+bN9WalIsGHRM/3gURSbT/GMkEQA== X-Received: by 2002:a1c:d106:: with SMTP id i6-v6mr1607399wmg.1.1527691777790; Wed, 30 May 2018 07:49:37 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o2-v6sm16022875wmo.24.2018.05.30.07.49.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 07:49:35 -0700 (PDT) Date: Wed, 30 May 2018 15:49:34 +0100 From: Leif Lindholm To: Thomas Abraham Cc: Sami Mujawar , nd@arm.com, Arvind Chauhan , Nariman Poushin , ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, Stephanie.Hughes-Fitt@arm.com, michael.d.kinney@intel.com Message-ID: <20180530144934.p2lt7er2vfqq4pvr@bivouac.eciton.net> References: <20180426130121.154724-1-sami.mujawar@arm.com> <20180426150831.7xo74s4cpkg62zst@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1] Platforms/ARM: Enable acpiview support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 14:49:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Apr 27, 2018 at 06:32:46PM +0530, Thomas Abraham wrote: > On Thu, Apr 26, 2018 at 8:38 PM, Leif Lindholm wrote: > > On Thu, Apr 26, 2018 at 02:01:21PM +0100, Sami Mujawar wrote: > >> Acpiview is a program that allows examination of ACPI table > >> contents from the UEFI Shell. > >> > >> Enable acpiview support as this can help with investigations, > >> especially at that stage where the tables are not enabling an > >> OS to boot. > > > > I have no objections to this, but I would prefer to see a comment from > > Arvind, Thomas or Daniil before merging. > > Adding Nariman to cc as well for good measure :) > > > > However, please use --subject-prefix="PATCH edk2-platforms“ in future. > > > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Sami Mujawar > >> Reviewed-by: Evan Lloyd > >> --- > >> The patch can be seen at: > >> https://github.com/samimujawar/edk2-platforms/tree/254_enable_acpiview_v1 > >> > >> Notes: > >> v1: > >> - Enable acpiview support in the UEFI shell for ARM platforms. [SAMI] > >> > >> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > >> index 7cb47937329efa1944ec4c156e2be995a755ce6f..0badb24f030a58363e7bee22a7cc1e03040b60aa 100644 > >> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > >> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > >> @@ -1,5 +1,5 @@ > >> # > >> -# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > >> +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. > >> # > >> # This program and the accompanying materials > >> # are licensed and made available under the terms and conditions of the BSD License > >> @@ -450,6 +450,7 @@ [Components.common] > >> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > >> + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf > > > > Although I would probably move this line up a few to improve sorting. > > > > Reviewed-by: Leif Lindholm > > > >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > Tested this patch with the Base RevC AEMv8 fvp and acpiview command > showed a very useful dump of the ACPI tables > > Tested-by: Thomas Abraham Thanks. Sami acknowledged my moving lines around off-list. Pushed as 5fc0e7b54b. / Leif