From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE05D2098C20A for ; Fri, 1 Jun 2018 02:51:54 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id 18-v6so1858343wml.2 for ; Fri, 01 Jun 2018 02:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nuJLLAaQEiQAf8dpOVdnMEPiWOUweJHbkjfpPUG/HgE=; b=E+DfeGoJMqEXiIwSqys0LlVM83AVwecGdWPwbXJMluRPILSdlFAnoWiuCavkQViz44 jAl+xZDsYpOSm1N2isbI8HgDNJTPi3yXsiAYvGGHCHSxLkC2CsxUjz+i+1ZzRIIE1ipJ pdYFCUpPsGYdu4wfwHa+8sHgYRE/aOHz/ufi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nuJLLAaQEiQAf8dpOVdnMEPiWOUweJHbkjfpPUG/HgE=; b=rKPpDBijFwZRpoh/WBpziOjqYQJrUce6tGMgPMdn5lSnY7IrYMO8tqTQtRXGVy5wFu I+oorjS6Z59zbKfE5m6a+hNqrrXN2JD9B2gNseRa8Vp9OUrRLFWDbf/nKV8UoyOnCWvm RCep2gU4S9S+aAaZ3P/BLsNq9oWg+v90rLzk7p3xF21ZA0iTVgW1hL3XKo7TDbygLoa/ pqKNqGYF0u2YqdwdeZR+ULwtnDzak4sKi66emXaNQ7kIC3oFTVUg/NI3ZepEZLvAulWj qnt1GP21gWVjiiwXvbl69g6RBcYQzwkywkG9dKlmsHfv8S67T/GTzkD/k8bhkXE8ZCp6 ex7A== X-Gm-Message-State: ALKqPwdz1PMtamt5rVNHRdGxk++kVbtuh9GwyRIU0SNKNjIK593NraGz FVghICDYTENupR8YSq9xQ7UrBg== X-Google-Smtp-Source: ADUXVKLWqc+2Ai1t+vp2B1AszO5dhcY7b2L6rVM/Qhy96jRJz2z5dR5en1KXm6AfL6dZRvlLZSit/w== X-Received: by 2002:a1c:f90e:: with SMTP id x14-v6mr2210472wmh.63.1527846712830; Fri, 01 Jun 2018 02:51:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m35-v6sm41157386wrm.51.2018.06.01.02.51.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Jun 2018 02:51:51 -0700 (PDT) Date: Fri, 1 Jun 2018 10:51:50 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180601095150.pfw65whgw7jwb3rd@bivouac.eciton.net> References: <20180316161322.6756-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180316161322.6756-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [RFC PATCH edk2-platforms 0/6] expand capsule to include SCP firmware X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 09:51:55 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 16, 2018 at 04:13:16PM +0000, Ard Biesheuvel wrote: > Now that the NOR flash layout has been updated to split the actual SCP > firmware from the startup code and the builtin flasher, we can add the > SCP image to the capsule update to make it field upgradeable. > > This involves some rather nasty plumbing, since making changes to capsule > update installable via capsule update requires some additional care. > > Patch #1 fixes a bug in the FVB handling code of the flash access library. > > Patch #2 addresses an issue where we accidentally started to dereference > arbitrary data as an FV header by incorporating the secure firmware binary > into the flash device. > > Patch #3 is an optimization that speeds up flashing of sparse capsules. > > Patch #4 adds a PCD that holds the minimum firmware version that is allowed > by a platform. We will use this to ensure that systems using the new layout > cannot be flashed using older capsules, which is unlikely to work in any > case, but not guaranteed to fail in a harmless manner. > > Patch #5 is a temporary hack we will need to use to build capsules that > allow upgrading from the old layout to the new layout > > Patch #6 implements the new layout, and adds support to set the minimum > version on the build command line. > > Ard Biesheuvel (6): > Silicon/SynQuacerPlatformFlashAccessLib: fix return value on no FVB > found > Silicon/SynQuacerPlatformFlashAccessLib: don't dereference FVB header > fields > Silicon/SynQuacerPlatformFlashAccessLib: skip empty blocks > Silicon/SynQuacer: make lowest supported f/w version PCD configurable > TEMPORARY > Platform/Socionext/DeveloperBox: add SCP firmware image to capsule I have a few comments on the 5/6 layout thing, but apart from that I'm happy with the series. I guess 4 doesn't make much sense before we're ready to include the SCP firmware in the build. But still - for 1-4/6: Reviewed-by: Leif Lindholm Feel free to push as many or as few of those as you like. > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 3 ++ > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 15 ++++--- > Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 2 + > Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 2 +- > Platform/Socionext/DeveloperBox/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 4 +- > Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.c | 46 ++++++++++++++++---- > Silicon/Socionext/SynQuacer/SynQuacer.dec | 3 ++ > 7 files changed, 58 insertions(+), 17 deletions(-) > > -- > 2.15.1 >