Re: [PATCH edk2-platforms 0/2] enable FPDT table for SynQuacer

[Leif Lindholm <leif.lindholm@linaro.org>]

On Thu, May 31, 2018 at 10:16:08PM +0100, Leif Lindholm wrote:
> On Thu, May 31, 2018 at 12:46:32PM +0200, Ard Biesheuvel wrote:
> > Enable some of the status code reporting infrastructure in patch #1 so
> > we can include the FPDT DXE driver in patch #2 which produces the FPDT
> > diagnostic table which tells us how much time was spent in the firmware,
> > in the OS loader, and in ExitBootServices().
> > 
> > Ard Biesheuvel (2):
> >   Platform/DeveloperBox: wire up status code reporting for DXE phase
> >   Platform/DeveloperBox: enable FPDT table
> 
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Hmm, after a side discussion with Ard, I have asked him _not_ to push
this set for now. The reason for this is that its use under Linux is
dependent on the fundamentally broken concept of directly mapping
physical address regions into non-privileged processes using /dev/mem.

I want to get a sane kernel interface in place for accessing this data
before we start encouraging its use.

If this holds anyone back for other operating systems, please speak up
(off-list if needs be). The Reviewed-by still applies, and the patches
are ready to go.

/
    Leif

> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 12 ++++++++++++
> >  Platform/Socionext/DeveloperBox/DeveloperBox.fdf |  2 ++
> >  Silicon/Socionext/SynQuacer/Acpi.dsc.inc         |  6 ++++++
> >  3 files changed, 20 insertions(+)
> > 
> > -- 
> > 2.17.0
> >