public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>,
	Younas Khan <pmdyounaskhan786@gmail.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: [RFC PATCH v1 0/2] Update and refine the IPMI header files
Date: Tue,  5 Jun 2018 11:20:08 +0800	[thread overview]
Message-ID: <20180605032010.25104-1-hao.a.wu@intel.com> (raw)

This series will:
a. Update the IPMI header files with the spec Intelligent Platform
   Management Interface Specification Second Generation v2.0 Document
   Revision 1.1 (October 1, 2013).
b. Refine those header files to use 'union' types for bitmap fields within
   structure definitions, so that both bit-level and byte/word-level
   accesses are provided.

The series is also available at:
https://github.com/hwu25/edk2/tree/ipmi_header_update


Please note that this series makes some incompatible changes:

a. For structure definition IPMI_EMP_DESTINATION_COM_SETTING:
Removes fields 'SaveSetting', 'SetComPort' and 'Reserved3' according to
IPMI v2.0 spec Table 25-4.

b. For structure definition IPMI_SET_SERIAL_MODEM_MUX_COMMAND_RESPONSE:
Add missing field 'CompletionCode' according to IPMI v2.0 spec Table 25-5.

c. For structure definition IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_5:
Update data 1, 4 and 5 according to IPMI v2.0 spec Table 28-14.

d. Add byte-word-level access for structures with bitmap fields.

But we cannot find any active users for those IPMI header files, and we
are lacking of means to perform functional tests for the changes within
this series.

If there is active users for these header files, help for the functional
test for this patch series will be very appreciated.

Cc: Younas Khan <pmdyounaskhan786@gmail.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>

Hao Wu (2):
  MdePkg/IndustryStandard/Ipmi: Update IPMI header files
  MdePkg/IndustryStandard/Ipmi: Use union for bitmap fields

 MdePkg/Include/IndustryStandard/Ipmi.h                      |  34 +-
 MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h |  92 +++
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h              | 546 ++++++++++++++++--
 MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h          | 327 ++++++++---
 MdePkg/Include/IndustryStandard/IpmiNetFnStorage.h          | 579 +++++++++++++------
 MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h        | 603 +++++++++++++++-----
 6 files changed, 1734 insertions(+), 447 deletions(-)
 create mode 100644 MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h

-- 
2.12.0.windows.1



             reply	other threads:[~2018-06-05  3:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05  3:20 Hao Wu [this message]
2018-06-05  3:20 ` [RFC PATCH v1 1/2] MdePkg/IndustryStandard/Ipmi: Update IPMI header files Hao Wu
2018-06-05  3:20 ` [RFC PATCH v1 2/2] MdePkg/IndustryStandard/Ipmi: Use union for bitmap fields Hao Wu
2018-06-19  4:48 ` [RFC PATCH v1 0/2] Update and refine the IPMI header files Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605032010.25104-1-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox