From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8AB2121199246 for ; Tue, 5 Jun 2018 07:55:30 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id w10-v6so2764679wrk.9 for ; Tue, 05 Jun 2018 07:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IN7LqeaCunehtouLebXzB8ICkM70u29hra39ECGlhKY=; b=XgD9WUbbq0Qm5kCp92lwwUQfXmd79jVBamCvcWWVYeoLA8MImTczxQvIxd/QxaYK6B P3qtwCxCG3TvI3gOlhAXWcsXhT8OcSFBrsaJ2IYI2jGamPPqx7gFkdZkfohsKcRZ+SYN Bg+y/lKKnuGG6ZyCbvFuH1HKhGQ5+wIa69gwE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IN7LqeaCunehtouLebXzB8ICkM70u29hra39ECGlhKY=; b=DRC1D3u+X8ItYBNDTsCwhAcBTgDAVdkKSLD9DyXVNMqHpje1KfbAP8cPCV5joGj5C2 zAe41BMqFXhzwDA1i88ZCpbhQ4347EcVbfO7PGKdjPswwNBX9Ac4UCUDxbgOroQ8kih3 os0wYnzwJARFqWhXfq4lruU4AQiecp5MpWeFchHp/rMdeWcQUHEsYv7Lnp5zxC9lW1CY 2b5AJjZ121V3VEErTbU/RL1VSsDvZ2OJCXq5xdyJAtO8MNJsE/CPUFWYDY/lAmlb3++4 HHyr6n1lDOxixRuszFSdbS7lj9AqDiGKzLh4/mVs3RKnzCXm5FvZHkTqAgjaXYJwCw32 GIXA== X-Gm-Message-State: APt69E0KaaxSh5bvdRwKcCMJjwRLgrxgXq7CvaR5esGFQtk+5EvffRYy QsblMwl12KZiHehBBU53dYabIA== X-Google-Smtp-Source: ADUXVKIuZ8TYEKjoItgC8ONl5eY2l3KDpXCCICF6qm5F9+//MqHvEJVu5PmxCRzB051v8zp1foIFSg== X-Received: by 2002:adf:fd05:: with SMTP id e5-v6mr1886666wrr.280.1528210529123; Tue, 05 Jun 2018 07:55:29 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q17-v6sm12711139wrs.5.2018.06.05.07.55.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 07:55:26 -0700 (PDT) Date: Tue, 5 Jun 2018 15:55:24 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: Haojian Zhuang , edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20180605145524.3auoepbsrebcjcn7@bivouac.eciton.net> References: <1524464514-14454-1-git-send-email-haojian.zhuang@linaro.org> <22e6f327-8330-d609-d86a-e7fa59c768ec@redhat.com> MIME-Version: 1.0 In-Reply-To: <22e6f327-8330-d609-d86a-e7fa59c768ec@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v4 0/2] add platform boot manager protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 14:55:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 23, 2018 at 10:15:41PM +0200, Laszlo Ersek wrote: > On 04/23/18 08:21, Haojian Zhuang wrote: > > Changelog: > > v4: > > * Add BootCount parameter in the interface. > > * Clean the logic on boot options according to Laszlo's comment. > > v3: > > * Update the name of interface. > > * Move the initialization into platform driver. > > * Fix comment style. > > * Fix minor issues with comments. > > v2: > > * Avoid to use hardcoding value. Create boot options by functions. > > > > Haojian Zhuang (2): > > EmbeddedPkg: add platform boot manager protocol > > ArmPkg/PlatformBootManagerLib: load platform boot options > > > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 103 +++++++++++++++++++++ > > .../PlatformBootManagerLib.inf | 2 + > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > EmbeddedPkg/Include/Protocol/PlatformBootManager.h | 86 +++++++++++++++++ > > 4 files changed, 192 insertions(+) > > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformBootManager.h > > > > (CC Leif, Ard) > > For the series: > Reviewed-by: Laszlo Ersek Thanks for the review Lazslo. Reviewed-by: Leif Lindholm Series pushed as 76022b02e8..1b6e7633ca. I will add that the bits that go into EmbeddedPkg here do so for no other reason than "we don't have a better place for them, and they're certainly not ARM-specific". The case for a generic UtilityPkg is growing. / Leif