From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8897E2110D503 for ; Thu, 7 Jun 2018 08:05:31 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id w10-v6so10210185wrk.9 for ; Thu, 07 Jun 2018 08:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6jCKmrJtDCLELIxP0kgdnT82IPJrhxYGaCTFYIPK2LU=; b=V4cAO6hZUauu+RtWI5MV/b+OiYgidie4ay6vF+sJYgtY+hzV5BOUOdmD0BUef50CIG gjVGe/w4KiEtc5U3IGJb0bFG4YRbfbjXfjkoeypuvUTMV8BfuF7dA6zzjNDvH2Lxxu7O uXQ+0AFOCYE61qjUl3RbDguAJq7dSZe8C50kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6jCKmrJtDCLELIxP0kgdnT82IPJrhxYGaCTFYIPK2LU=; b=LGKCof53YOMjyycf5IijuCx+6Gug36ppdyBTrwG35IOZ+6iMQ5pQSqlghOZq+tA19O 36Zv+asjKg47QUrtx3CM5MkSfbpfj7HPFFfED1ImMO3wVYvfDkI0HbsUhcrK4EEcmRLa uawmMRpEJU+U3u9jP1lzO1svlp+0JhwwB9/SHyTR0eEJoFMS4MTANMapG07HgYk7eYqz px9reEOvghNf2fy0+jWeKlbj8VUPgG1l44bmfAmVbHGO49Ae77CjWNpViFOitYh/fdfA R05ijKF7rn8ACro+giqTIPyDI3eNMtvgee2dLrj3gmFWVJdnyPhCdn/SYCW3yg7bJyTp Kv+g== X-Gm-Message-State: APt69E2ACizdnj61aN2/C2gW8m3NzqXacm4nTx0yxnO93oEMzl+jbAgc 0KGTZxfAPzg4O3lHm5EPZT3skQ== X-Google-Smtp-Source: ADUXVKLDPCuCXg6XjbGssmUe1OXSiOiF63GXclxLrWEM62juebQdFbnsmjwMzfKpC35lddWGpp1p4w== X-Received: by 2002:adf:c4b6:: with SMTP id m51-v6mr2057774wrf.103.1528383929965; Thu, 07 Jun 2018 08:05:29 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s13-v6sm14610986wrq.48.2018.06.07.08.05.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 08:05:23 -0700 (PDT) Date: Thu, 7 Jun 2018 16:04:46 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, michael.d.kinney@intel.com, jiewen.yao@intel.com, star.zeng@intel.com Message-ID: <20180607150446.2gfebruzqrvew5u5@bivouac.eciton.net> References: <20180607110812.26778-1-ard.biesheuvel@linaro.org> <20180607110812.26778-5-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180607110812.26778-5-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 4/5] ArmPkg/PlatformBootManagerLib: call ProcessCapsules() only once X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 15:05:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 07, 2018 at 01:08:11PM +0200, Ard Biesheuvel wrote: > ARM platforms have no restriction on when a system firmware update > capsule can be applied, and so it is not necessary to call > ProcessCapsules() twice. So let's drop the first invocation that > occurs before EndOfDxe, so that capsule updates will be applied > when the console is up and able to provide progress feedback. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index 3456a71fbb9c..8e1ecdc01564 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -553,21 +553,6 @@ PlatformBootManagerBeforeConsole ( > VOID > ) > { > - EFI_STATUS Status; > - ESRT_MANAGEMENT_PROTOCOL *EsrtManagement; > - > - if (GetBootModeHob() == BOOT_ON_FLASH_UPDATE) { > - DEBUG ((DEBUG_INFO, "ProcessCapsules Before EndOfDxe ......\n")); > - Status = ProcessCapsules (); > - DEBUG ((DEBUG_INFO, "ProcessCapsules returned %r\n", Status)); > - } else { > - Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, > - (VOID **)&EsrtManagement); > - if (!EFI_ERROR (Status)) { > - EsrtManagement->SyncEsrtFmp (); > - } > - } > - > // > // Signal EndOfDxe PI Event > // > -- > 2.17.0 >