From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Yanyan Sun <yanyan.sun@intel.com>,
Yonghong Zhu <yonghong.zhu@intel.com>,
Liming Gao <liming.gao@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [Patch 2/5] BaseTools/BinToPcd: Clarify error message for --type HII
Date: Fri, 8 Jun 2018 23:15:02 -0700 [thread overview]
Message-ID: <20180609061505.14380-3-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20180609061505.14380-1-michael.d.kinney@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=963
Update error message for --type HII. If either --variable-guid
or --variable-name is missing, then print an error message that
states that both --variable-guid and --variable-name are required.
Cc: Yanyan Sun <yanyan.sun@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
BaseTools/Scripts/BinToPcd.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/BaseTools/Scripts/BinToPcd.py b/BaseTools/Scripts/BinToPcd.py
index 014aad9800..7e3380190e 100644
--- a/BaseTools/Scripts/BinToPcd.py
+++ b/BaseTools/Scripts/BinToPcd.py
@@ -186,11 +186,8 @@ if __name__ == '__main__':
print ' [PcdsDynamicVpd]'
print ' [PcdsDynamicExVpd]'
elif args.PcdType == 'HII':
- if args.VariableGuid is None:
- print 'BinToPcd: error: argument --variable-guid is required for --type HII.'
- sys.exit()
- if args.VariableName is None:
- print 'BinToPcd: error: argument --variable-name is required for --type HII.'
+ if args.VariableGuid is None or args.VariableName is None:
+ print 'BinToPcd: error: arguments --variable-guid and --variable-name are required for --type HII.'
sys.exit()
if args.Offset is None:
#
--
2.14.2.windows.3
next prev parent reply other threads:[~2018-06-09 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 6:15 [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks Kinney, Michael D
2018-06-09 6:15 ` [Patch 1/5] BaseTools/BinToPcd: Fix typo in error messages Kinney, Michael D
2018-06-09 6:15 ` Kinney, Michael D [this message]
2018-06-09 6:15 ` [Patch 3/5] BaseTools/BinToPcd: --offset must be 8-byte aligned Kinney, Michael D
2018-06-09 6:15 ` [Patch 4/5] BaseTools/BinToPcd: Update for Python 3 compatibility Kinney, Michael D
2018-06-09 6:15 ` [Patch 5/5] BaseTools/BinToPcd: Follow PEP-8 indent of 4 spaces Kinney, Michael D
2018-06-12 0:40 ` [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609061505.14380-3-michael.d.kinney@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox