Re: [PATCH 2/4] OvmfPkg: add QemuRamfbDxe

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> > +  {
> > +    .HorizontalResolution  = 640,
> > +    .VerticalResolution    = 480,
> > +  },{
> > +    .HorizontalResolution  = 800,
> > +    .VerticalResolution    = 600,
> > +  },{
> > +    .HorizontalResolution  = 1024,
> > +    .VerticalResolution    = 768,
> > +  }
> > +};
> 
> (10) In edk2 we cannot use designated initializers. I suggest (for
> example) assigning these values in the entry point function.

Really?  C99 is almost 20 years old now ...
Are there compilers left without C99 support which edk2 still supports?

> In general, in edk2 there are two accepted indentation styles for
> function calls that extend to multiple lines:
> 
> variant #1: all arguments (including the first one) on separate lines,
> with the closing paren also on a separate line:
> 
>   Status = StructPointer->Function (
>                             Arg1,
>                             Arg2,
>                             Arg3
>                             );

Hmm, pretty unusual, which is bad for editor auto-indent support.
Anyone knows tricks to teack emacs that style?

cheers,
  Gerd