From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kraxel@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=kraxel@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 0D6062110E8A4
 for <edk2-devel@lists.01.org>; Tue, 12 Jun 2018 02:15:54 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id EB06D7D84D
 for <edk2-devel@lists.01.org>; Tue, 12 Jun 2018 09:15:53 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-116-109.ams2.redhat.com
 [10.36.116.109])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 8E80B2023450;
 Tue, 12 Jun 2018 09:15:53 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
 id E734311AB8; Tue, 12 Jun 2018 11:15:52 +0200 (CEST)
Date: Tue, 12 Jun 2018 11:15:52 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel@lists.01.org
Message-ID: <20180612091552.uoo74cvqfzuf364t@sirius.home.kraxel.org>
References: <20180608113942.17009-1-kraxel@redhat.com>
 <20180608113942.17009-3-kraxel@redhat.com>
 <dd112b75-999e-6211-8fb9-bd2fbdd0714e@redhat.com>
MIME-Version: 1.0
In-Reply-To: <dd112b75-999e-6211-8fb9-bd2fbdd0714e@redhat.com>
User-Agent: NeoMutt/20180512
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.2]); Tue, 12 Jun 2018 09:15:53 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]);
 Tue, 12 Jun 2018 09:15:53 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'kraxel@redhat.com' RCPT:''
Subject: Re: [PATCH 2/4] OvmfPkg: add QemuRamfbDxe
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 09:15:56 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > +  {
> > +    .HorizontalResolution  = 640,
> > +    .VerticalResolution    = 480,
> > +  },{
> > +    .HorizontalResolution  = 800,
> > +    .VerticalResolution    = 600,
> > +  },{
> > +    .HorizontalResolution  = 1024,
> > +    .VerticalResolution    = 768,
> > +  }
> > +};
> 
> (10) In edk2 we cannot use designated initializers. I suggest (for
> example) assigning these values in the entry point function.

Really?  C99 is almost 20 years old now ...
Are there compilers left without C99 support which edk2 still supports?

> In general, in edk2 there are two accepted indentation styles for
> function calls that extend to multiple lines:
> 
> variant #1: all arguments (including the first one) on separate lines,
> with the closing paren also on a separate line:
> 
>   Status = StructPointer->Function (
>                             Arg1,
>                             Arg2,
>                             Arg3
>                             );

Hmm, pretty unusual, which is bad for editor auto-indent support.
Anyone knows tricks to teack emacs that style?

cheers,
  Gerd