Re: [platforms PATCH 02/25] Marvell/Library: Introduce ArmadaBoardDescLib class

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Jun 08, 2018 at 05:34:00PM +0200, Marcin Wojtas wrote:
> This patch adds a new library class that will be helpful
> to describe a per-board information, which will be
> processed by BoardDesc protocol.
> 
> Together with ArmadaSoCDescLib data it will be a flexible
> solution allowing to provide complete information to
> the drivers, replacing faulty MvHwDescLib.h.
> 
> Initially ArmadaBoardDescLib defines per-board UTMI
> PHYs information structure.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Reviewed-by: Hua Jing <jinghua@marvell.com>

As Ard said, please drop Reviewed-by:s (but add Author: where useful,
or add internal reviewer on cc so they can review in public, where
possible).

With that
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---
>  Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 27 ++++++++++++++++++++
>  Silicon/Marvell/Marvell.dec                          |  1 +
>  2 files changed, 28 insertions(+)
> 
> diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> new file mode 100644
> index 0000000..2d50067
> --- /dev/null
> +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> @@ -0,0 +1,27 @@
> +/**
> +*
> +*  Copyright (C) 2018, Marvell International Ltd. and its affiliates
> +*
> +*  This program and the accompanying materials are licensed and made available
> +*  under the terms and conditions of the BSD License which accompanies this
> +*  distribution. The full text of the license may be found at
> +*  http://opensource.org/licenses/bsd-license.php
> +*
> +*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +*
> +**/
> +#ifndef __ARMADA_BOARD_DESC_LIB_H__
> +#define __ARMADA_BOARD_DESC_LIB_H__
> +
> +#include <Library/ArmadaSoCDescLib.h>
> +
> +//
> +// UTMI PHY devices per-board description
> +//
> +typedef struct {
> +  MV_SOC_UTMI_DESC *SoC;
> +  UINT8             UtmiDevCount;
> +  UINT8             UtmiPortType;
> +} MV_BOARD_UTMI_DESC;
> +#endif /* __ARMADA_SOC_DESC_LIB_H__ */
> diff --git a/Silicon/Marvell/Marvell.dec b/Silicon/Marvell/Marvell.dec
> index 2a92eff..db49300 100644
> --- a/Silicon/Marvell/Marvell.dec
> +++ b/Silicon/Marvell/Marvell.dec
> @@ -60,6 +60,7 @@
>    gMarvellSpiFlashDxeGuid = { 0x49d7fb74, 0x306d, 0x42bd, { 0x94, 0xc8, 0xc0, 0xc5, 0x4b, 0x18, 0x1d, 0xd7 } }
>  
>  [LibraryClasses]
> +  ArmadaBoardDescLib|Include/Library/ArmadaBoardDescLib.h
>    ArmadaSoCDescLib|Include/Library/ArmadaSoCDescLib.h
>    SampleAtResetLib|Include/Library/SampleAtResetLib.h
>  
> -- 
> 2.7.4
>