From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 42E0D21236EBD for ; Tue, 12 Jun 2018 08:36:57 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id o12-v6so24555181wrm.12 for ; Tue, 12 Jun 2018 08:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9BwnPJBmCeOmJ1mKtFUwg5b76X04sf0TbBmbHJ/4mCc=; b=Ul3TUPv0D8GCwB+DPX00GkJfOdhUxKkLyMZcHFn9nJiS2Ixos6aJwHc17ivqRyauwZ 9+UEanUKuDTi8wSRQsHCktMUInekmSZyO3uVjFRIKB2V2tJPgFVFIVoyBUMqQEedZbY1 T2AX1SstIazZTKjjQKpDJU0NJrKhDJkzp47TA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9BwnPJBmCeOmJ1mKtFUwg5b76X04sf0TbBmbHJ/4mCc=; b=VTWKI9DsehXNRAHIKiWx6gGjBaGNLbOKiP3WQos2twfsg+D9D5UZ3uETjC88E/y1ov WkjbU7MexGAXAGXvgwDgr9iWf9qJnoRRORpk4+0B3D/7nOODKnGCD2E3yFMBHtqHqASo BPFwjU85fCnZGwaMHIzm8FSgEs6h9XEnPDyKA35L8vAxzY50Vvap9dg+2eMJQuCSD1yl Dd/LrofuU7+W5YxuF9jzk9j/KEJp1wlApW42bvA4kJX7ggKx+cDMwTLGPrKiotB/SsaK qjus28jvY1+00zpx7QCuLhgBuhvl6qE/Buy/QjrSoZvj5NF+Oj9+Q3CyWLCY7wzDsXsN fjdQ== X-Gm-Message-State: APt69E34aeVAWWdFProfkg6wMrPCI+R+LrBOx3AUdlgPPxiDMDF+iK6b IUlwmNH+t7VV7htdOkI9WLcIOg== X-Google-Smtp-Source: ADUXVKJgsEMTywZdvRh/YB3lfMXvsyP2Vaojc2KiHv7MpsD6iH64q7hac9SzBDOFy4zDvjkeh8IjYQ== X-Received: by 2002:adf:a9c1:: with SMTP id b59-v6mr714461wrd.48.1528817816540; Tue, 12 Jun 2018 08:36:56 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n7-v6sm529082wrr.39.2018.06.12.08.36.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Jun 2018 08:36:55 -0700 (PDT) Date: Tue, 12 Jun 2018 16:36:54 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jinghua@marvell.com, jsd@semihalf.com, jaz@semihalf.com Message-ID: <20180612153654.r2btivoycgvgnpzv@bivouac.eciton.net> References: <1528472063-1660-1-git-send-email-mw@semihalf.com> <1528472063-1660-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1528472063-1660-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms PATCH 02/25] Marvell/Library: Introduce ArmadaBoardDescLib class X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 15:36:58 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 08, 2018 at 05:34:00PM +0200, Marcin Wojtas wrote: > This patch adds a new library class that will be helpful > to describe a per-board information, which will be > processed by BoardDesc protocol. > > Together with ArmadaSoCDescLib data it will be a flexible > solution allowing to provide complete information to > the drivers, replacing faulty MvHwDescLib.h. > > Initially ArmadaBoardDescLib defines per-board UTMI > PHYs information structure. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > Reviewed-by: Hua Jing As Ard said, please drop Reviewed-by:s (but add Author: where useful, or add internal reviewer on cc so they can review in public, where possible). With that Reviewed-by: Leif Lindholm > --- > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 27 ++++++++++++++++++++ > Silicon/Marvell/Marvell.dec | 1 + > 2 files changed, 28 insertions(+) > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > new file mode 100644 > index 0000000..2d50067 > --- /dev/null > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > @@ -0,0 +1,27 @@ > +/** > +* > +* Copyright (C) 2018, Marvell International Ltd. and its affiliates > +* > +* This program and the accompanying materials are licensed and made available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > +#ifndef __ARMADA_BOARD_DESC_LIB_H__ > +#define __ARMADA_BOARD_DESC_LIB_H__ > + > +#include > + > +// > +// UTMI PHY devices per-board description > +// > +typedef struct { > + MV_SOC_UTMI_DESC *SoC; > + UINT8 UtmiDevCount; > + UINT8 UtmiPortType; > +} MV_BOARD_UTMI_DESC; > +#endif /* __ARMADA_SOC_DESC_LIB_H__ */ > diff --git a/Silicon/Marvell/Marvell.dec b/Silicon/Marvell/Marvell.dec > index 2a92eff..db49300 100644 > --- a/Silicon/Marvell/Marvell.dec > +++ b/Silicon/Marvell/Marvell.dec > @@ -60,6 +60,7 @@ > gMarvellSpiFlashDxeGuid = { 0x49d7fb74, 0x306d, 0x42bd, { 0x94, 0xc8, 0xc0, 0xc5, 0x4b, 0x18, 0x1d, 0xd7 } } > > [LibraryClasses] > + ArmadaBoardDescLib|Include/Library/ArmadaBoardDescLib.h > ArmadaSoCDescLib|Include/Library/ArmadaSoCDescLib.h > SampleAtResetLib|Include/Library/SampleAtResetLib.h > > -- > 2.7.4 >