From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A1E9C20979D4F for ; Fri, 15 Jun 2018 02:03:44 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id l15-v6so5992409wmc.1 for ; Fri, 15 Jun 2018 02:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gfhmc3C4wlacMprH+BMSqdm98Vp4abkBx5Pti+Wdx20=; b=f6i2wXMNXjsWpqmZPeXKTgYpgoa1II0T+LIBNDlMfE0yWDnlFVB+cAs14km+dqMRL4 iEQnJ7QH0k2udm/ZoxmbO4/0t56oXLxabrQU8I5XB2j65awwzThedFoGCVzKXzjpaGrW eY1d8VL+4WIXQkQvuZjZSXElp1Tqr/ElnDXBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gfhmc3C4wlacMprH+BMSqdm98Vp4abkBx5Pti+Wdx20=; b=Jsm0FIifORdruiH9OUSsB6fy9FVhCcEXR5RR95X7vRnP3le5RCxvTvd18BUtqseckw OBeE9pLCeXIycK1i9BZ3cchSolFkk70DPlpcR3JB5Qfk2r+NcSMGqKZ1H98et7VOLO+D kFdT0lbteSDxOLCzm1P7NdaIreV25ZWPkS3oWlKXmh4s7Np8XZ98Z5naIgd3OfYUJwdu XANsU2BupD/t6hEj03Y259TnTBBQxik+sGe5TnvsMfR0lyLzYQA5A1774hJ5QSrFerGq HuUdDP+6vhYwm6CMzcsogZWc4o0/FewAwA4gK+ba/SOPbCsUp0sGhV53dGjrA2Y2kKGV /6gg== X-Gm-Message-State: APt69E2ZQkTzfvm5ZPbfJEN65dlXTzkKpCqYOxmJGMHzwGZMPCvb0F5W d1R28n0HQ2I5xIlfUzxeP8QQuQ== X-Google-Smtp-Source: ADUXVKJ/FIjoqJszKvtN4aRVA6iE/ROvGlrr6KHVl5HFJ/bmOU+WxD2oewimIfqG0p0Ujwu79rp6OA== X-Received: by 2002:a1c:850c:: with SMTP id h12-v6mr559879wmd.116.1529053422757; Fri, 15 Jun 2018 02:03:42 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d102-v6sm1422532wma.10.2018.06.15.02.03.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 02:03:41 -0700 (PDT) Date: Fri, 15 Jun 2018 10:03:39 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Chandni Cherukuri , "edk2-devel@lists.01.org" Message-ID: <20180615090339.23bls2l7jyudbusw@bivouac.eciton.net> References: <1529042132-29377-1-git-send-email-chandni.cherukuri@arm.com> <1529042132-29377-2-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] Platform/ARM/Sgi: Install a Platform ID HOB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 09:03:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 15, 2018 at 08:19:35AM +0200, Ard Biesheuvel wrote: > On 15 June 2018 at 08:16, Ard Biesheuvel wrote: > >> diff --git a/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf b/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> new file mode 100644 > >> index 0000000..502d6ac > >> --- /dev/null > >> +++ b/Platform/ARM/SgiPkg/Library/SgiPlatformPeiLib/SgiPlatformPeiLib.inf > >> @@ -0,0 +1,40 @@ > >> +# > >> +# Copyright (c) 2018, ARM Limited. All rights reserved. > >> +# > >> +# This program and the accompanying materials are licensed and made available > >> +# under the terms and conditions of the BSD License which accompanies this > >> +# distribution. The full text of the license may be found at > >> +# http://opensource.org/licenses/bsd-license.php > >> +# > >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> +# > >> + > >> +[Defines] > >> + INF_VERSION = 0x0001001A > >> + BASE_NAME = SgiPlatformIdPeiLib > > I forgot: this is a module not a library. So it should be called > SgiPlatformIdPei or SgiPlatformIdPeim not ...Lib A grep through the edk2 tree suggests that: - the directory is usually called *Pei - .inf/.uni usually *Pei.* - entry point and source files *Peim* / Leif > >> + FILE_GUID = a9936f3e-6a1b-11e8-8ce0-fffe69b86863 > >> + MODULE_TYPE = PEIM > >> + VERSION_STRING = 1.0 > >> + ENTRY_POINT = SgiPlatformIdPeim > >> + > >> +[Packages] > >> + EmbeddedPkg/EmbeddedPkg.dec > >> + MdePkg/MdePkg.dec > >> + Platform/ARM/SgiPkg/SgiPlatform.dec > >> + > >> +[LibraryClasses] > >> + FdtLib > >> + PeimEntryPoint > >> + > >> +[Sources] > >> + SgiPlatformPeiLib.c > >> + > >> +[Guids] > >> + gArmSgiPlatformIdDescriptorGuid > >> + > >> +[Ppis] > >> + gHwConfigDtInfoPpiGuid > >> + > >> +[Depex] > >> + TRUE > >> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiPlatform.dec > >> index d995937..ea9f6c5 100644 > >> --- a/Platform/ARM/SgiPkg/SgiPlatform.dec > >> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec > >> @@ -29,9 +29,14 @@ > >> Include # Root include for the package > >> > >> [Guids.common] > >> + # ARM Sgi Platform ID descriptor > >> + gArmSgiPlatformIdDescriptorGuid = { 0xf56f152a, 0xad2a, 0x11e6, { 0xb1, 0xa7, 0x00, 0x50, 0x56, 0x3c, 0x44, 0xcc } } > >> gArmSgiTokenSpaceGuid = { 0x577d6941, 0xaea1, 0x40b4, { 0x90, 0x93, 0x2a, 0x86, 0x61, 0x72, 0x5a, 0x57 } } > >> gSgi575AcpiTablesiFileGuid = { 0xc712719a, 0x0aaf, 0x438c, { 0x9c, 0xdd, 0x35, 0xab, 0x4d, 0x60, 0x20, 0x7d } } > >> > >> [PcdsFeatureFlag.common] > >> # Set this PCD to TRUE to enable virtio support. > >> gArmSgiTokenSpaceGuid.PcdVirtioSupported|TRUE|BOOLEAN|0x00000001 > >> + > >> +[Ppis] > >> + gHwConfigDtInfoPpiGuid = { 0x6f606eb3, 0x9123, 0x4e15, { 0xa8, 0x9b, 0x0f, 0xac, 0x66, 0xef, 0xd0, 0x17 } } > >> -- > >> 2.7.4 > >>