From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 62B83210F529C for ; Fri, 15 Jun 2018 05:40:37 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id d8-v6so9809893wro.4 for ; Fri, 15 Jun 2018 05:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=paerUseDpEKQFHQka0bnQSSYPou+YD5m85pE3oZAGSg=; b=cKAP2HAgr0N3lsXNLb4dmtnZWb8Ay4pC6Hj5ZfGSQw+u9fDBF6LmBtF+3a5wKkj0Sp bflNhyDN4WOBuorBmwpBse78KWxqkA4hWgJxYdmJeuuuq5IEJ7ypipOHDRFl2Q5kINBt TdWH2PDor6nWxGrONVsOAIT9gvxdGbhC8JPsA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=paerUseDpEKQFHQka0bnQSSYPou+YD5m85pE3oZAGSg=; b=qwUg8OCpDvBy8/iIK0b7UE87hAWm+YP2v6LgrG7PdBLQzE9LCwvuA8qkPkdH1SEePu 0efR+/nDI6+j1hfxV4d6t2P57+1ZvOwejuQJn1mCnFnYYfCf3PKpjKZiGyE8ZqdvtUCM v5DfVR/0NnT36wQw/JEIZVVoYnodRqhP61xjbfrOYYphwmvo2BYF5lmxdKE90XYccLgl 8DUGZ7pprZbc25SRdxN34ZXXjS2lfY2sDJbI3mAK7IsnV6Y3W2KlK8khIncTlZcJ9gDY Wra8N43A7YEQJBN8CfbQYfVnd9WiasnqRDuFl91yR8I+nW66tEPKbvjlgV9Rpw1n9WXs O2dw== X-Gm-Message-State: APt69E2mxpl8wjglGpYz+xKKCmXiQUI8kh5I6a88R97GmNUNKS0PFq6q YlFY9blN352Rayd0M/m6pXc74Q== X-Google-Smtp-Source: ADUXVKLDt+kOIvCMm4L5QNLAD4ALQi42DYgc9tainQVTKOBW6jAWKVgzIF1gsSmKLhIT4VpUj/6hBw== X-Received: by 2002:a5d:4204:: with SMTP id n4-v6mr1467416wrq.55.1529066436393; Fri, 15 Jun 2018 05:40:36 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h65-v6sm1724952wmf.7.2018.06.15.05.40.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 05:40:35 -0700 (PDT) Date: Fri, 15 Jun 2018 13:40:33 +0100 From: Leif Lindholm To: Chandni Cherukuri Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20180615124033.lf7jp67jmr2xkhml@bivouac.eciton.net> References: <1529064002-18779-1-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: <1529064002-18779-1-git-send-email-chandni.cherukuri@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 0/2] ARM Dynamic Configuration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 12:40:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 15, 2018 at 05:30:00PM +0530, Chandni Cherukuri wrote: > On SGI platforms, the trusted firmware executes prior to the SEC > phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt > in the x1 which contains platform specific information such as part > number and config number of the SGI platform. > > The HW CONFIG FDT would look as, > /dts-v1/; > / { > /* compatible string */ > compatible = "arm,sgi-isys3"; > > /* platform ID node */ > system-id { > platform-id = <0x03000783>; > } > }; > > In the very first step of the assembly code which executes in SEC phase > the fdt pointer is stored in a global variable from the register. A PPI > is created during the SEC phase which stores the global variable. > > During PEI phase, a Platform ID PEIM is installed which accessess the PPI > and retrieves the platform information using FDT helper functions and a > PlatformId HOB is created and populated with the information. > > During DXE phase the drivers can access the Platform ID HOB to get the > platform information and perform platform specific functions based on the > platform. It's helpful for subsequent revisions to keep a revision history in cover letter. Changes since v1: - ... - ... - ... Kept around and added to for subsequent revisions. However, you've addressed all of my comments on v1, so for my part - for the series: Reviewed-by: Leif Lindholm But we want to hear back from Ard as well. / Leif > Chandni Cherukuri (2): > Platform/ARM/Sgi: Install a Platform ID HOB > Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33 +++++- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + > Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 ++++ > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ > Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 10 ++ > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 3 + > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf | 40 +++++++ > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 112 ++++++++++++++++++++ > Platform/ARM/SgiPkg/SgiPlatform.dec | 5 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > 12 files changed, 247 insertions(+), 9 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h > create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf > create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c > > -- > 2.7.4 > >