From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E558210EE4DD for ; Mon, 18 Jun 2018 09:45:54 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id n5-v6so16822019wmc.5 for ; Mon, 18 Jun 2018 09:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SvA7YxMKOu02bgPyr4bcxDMxZvxk+tdIQPolDTGmLrA=; b=VNgsNtF7wwB1Av8RtNnZmyzYDUwn0KViJvJE8f64T42NBsCcjhBGt2O2dB9tDWFp6o sjNGndAf3Q+Sdqb5w+NucIn45ctHqgmM3EmrO+eAkA6uQxopoaMDssncj4FstXdE5RNr XmjB3YJgF8IKb7dj9biFVOx7fv/dreGcY1qh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SvA7YxMKOu02bgPyr4bcxDMxZvxk+tdIQPolDTGmLrA=; b=VRLCcwghEDcqe//TZ/bGeTDDSiyHzA0PmIm8hLdMQQU9SJK6+klheGRPFVNcwfiOcJ 1ZJ1/ZT/ImiTmpGYG29NJox2JI6608LmbbG2qIQilMQjWY32OLwihj40K15iC3eYEWn6 o6XCCoQsaY87XsJzKuJ9mxs+dXPcGu84mEhVImnbC4RMqkSueGhgHFfGhlpT/hdldEmh cdnguy508E7Mh0Ty6kk+ch2sU6Rbyj2QdTLU6L+7uf3m9hlPOmIMH3utqYaSvzDftxPo cH3uCxq/gSH9FNHLC8vqWDE8gqp/o18EI6tEl7/WTy30MuOXapUSj09gkbc6G+RwC/2x QBPQ== X-Gm-Message-State: APt69E0mem/54aBXQQU2hdTthW+RSxXD7+c5E140CWDqjptmW3iUYQM4 ikVT016EcC+hZQKwxPYxcuilmw== X-Google-Smtp-Source: ADUXVKJErEV6nyaqkfHG7yBu2iu9aOgU1CjXonXpAgg+Y0kkYNh9zAP1LW5Sov8lB17nWpbSAp25Bg== X-Received: by 2002:a1c:7401:: with SMTP id p1-v6mr8891205wmc.14.1529340352973; Mon, 18 Jun 2018 09:45:52 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v31-v6sm37005968wrc.80.2018.06.18.09.45.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 09:45:51 -0700 (PDT) Date: Mon, 18 Jun 2018 17:45:50 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jinghua@marvell.com, jsd@semihalf.com, jaz@semihalf.com Message-ID: <20180618164550.4c5aqfegyown4ls2@bivouac.eciton.net> References: <1529266325-18371-1-git-send-email-mw@semihalf.com> <1529266325-18371-23-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1529266325-18371-23-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 22/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 16:45:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jun 17, 2018 at 10:12:02PM +0200, Marcin Wojtas wrote: > This patch introduces new library callback (ArmadaSoCDescI2cGet ()), > which dynamically allocates and fills MV_SOC_I2C_DESC structure with > the SoC description of I2c controllers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm > --- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 ++++ > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 15 ++++++++++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 31 ++++++++++++++++++++ > 3 files changed, 52 insertions(+) > > diff --git a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > index c864f94..b1219c4 100644 > --- a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > +++ b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > @@ -38,6 +38,12 @@ > #define MV_SOC_COMPHY_MUX_BITS 4 > > // > +// Platform description of I2C controllers > +// > +#define MV_SOC_I2C_PER_CP_COUNT 2 > +#define MV_SOC_I2C_BASE(I2c) (0x701000 + ((I2c) * 0x100)) > + > +// > // Platform description of MDIO controllers > // > #define MV_SOC_MDIO_BASE(Cp) (MV_SOC_CP_BASE ((Cp)) + 0x12A200) > diff --git a/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h b/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > index 304d068..d2bcf2a 100644 > --- a/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > +++ b/Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > @@ -37,6 +37,21 @@ ArmadaSoCDescComPhyGet ( > ); > > // > +// I2C > +// > +typedef struct { > + UINTN I2cId; > + UINTN I2cBaseAddress; > +} MV_SOC_I2C_DESC; > + > +EFI_STATUS > +EFIAPI > +ArmadaSoCDescI2cGet ( > + IN OUT MV_SOC_I2C_DESC **I2cDesc, > + IN OUT UINTN *DescCount > + ); > + > +// > // MDIO > // > typedef struct { > diff --git a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > index 652677f..6ce6bad 100644 > --- a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > +++ b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > @@ -63,6 +63,37 @@ ArmadaSoCDescComPhyGet ( > > EFI_STATUS > EFIAPI > +ArmadaSoCDescI2cGet ( > + IN OUT MV_SOC_I2C_DESC **I2cDesc, > + IN OUT UINTN *DescCount > + ) > +{ > + MV_SOC_I2C_DESC *Desc; > + UINTN CpCount, CpIndex, Index; > + > + CpCount = FixedPcdGet8 (PcdMaxCpCount); > + > + *DescCount = CpCount * MV_SOC_I2C_PER_CP_COUNT; > + Desc = AllocateZeroPool (*DescCount * sizeof (MV_SOC_I2C_DESC)); > + if (Desc == NULL) { > + DEBUG ((DEBUG_ERROR, "%a: Cannot allocate memory\n", __FUNCTION__)); > + return EFI_OUT_OF_RESOURCES; > + } > + > + *I2cDesc = Desc; > + > + for (CpIndex = 0; CpIndex < CpCount; CpIndex++) { > + for (Index = 0; Index < MV_SOC_I2C_PER_CP_COUNT; Index++) { > + Desc->I2cBaseAddress = MV_SOC_CP_BASE (CpIndex) + MV_SOC_I2C_BASE (Index); > + Desc++; > + } > + } > + > + return EFI_SUCCESS; > +} > + > +EFI_STATUS > +EFIAPI > ArmadaSoCDescMdioGet ( > IN OUT MV_SOC_MDIO_DESC **MdioDesc, > IN OUT UINTN *DescCount > -- > 2.7.4 >