Re: [platforms: PATCH v2 18/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Jun 18, 2018 at 06:27:47PM +0200, Marcin Wojtas wrote:
> 2018-06-18 18:23 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
> > On Sun, Jun 17, 2018 at 10:11:58PM +0200, Marcin Wojtas wrote:
> >> This patch introduces new library callback (ArmadaSoCDescMdioGet ()),
> >> which dynamically allocates and fills MV_SOC_MDIO_DESC structure with
> >> the SoC description of Mdio controllers.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> >> ---
> >>  Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h |  6 ++++
> >>  Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h                             | 15 ++++++++++
> >>  Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 29 ++++++++++++++++++++
> >>  3 files changed, 50 insertions(+)
> >>
> >> diff --git a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h
> >> index f372ca0..c864f94 100644
> >> --- a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h
> >> +++ b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h
> >> @@ -38,6 +38,12 @@
> >>  #define MV_SOC_COMPHY_MUX_BITS           4
> >>
> >>  //
> >> +// Platform description of MDIO controllers
> >> +//
> >> +#define MV_SOC_MDIO_BASE(Cp)             (MV_SOC_CP_BASE ((Cp)) + 0x12A200)
> >
> > Still pointless double parentheses around this Cp :)
> > Save that for a single patch later on, as commented on earlier patch
> > in set.
> > (This version already fixes the bug.)
> 
> I can quickly update each patch, unless you really wish to do it
> separately. Please confirm your preferences.

Ah, right, I got it in my head this file existed before this series,
but that isn't the case. Sure, if you can update them all on initial
introduction, that'd be nice.

Best Regards,

Leif