From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 88D80210ED793 for ; Mon, 18 Jun 2018 10:17:03 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id l15-v6so15757795wmc.1 for ; Mon, 18 Jun 2018 10:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XAfPlPSIQJNKDPs3SN1QIi8OsbvB5CO/JbZQYkhlt64=; b=MqudcIA/25enRpJv7M4pK4pHeHsk1EAmUF+sUUYuhGh8NqMqFShGqtGVSWhd2wK5u5 CDr2UpTOx48zv1NsGP3c2cJqRsdMY1DOPz9NOHTideIHd49gcuT4x3zw8SvJorT2E3gG CndrTa8z6WJ3RkfdOTaARuSl6oHjabnx8E0bo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XAfPlPSIQJNKDPs3SN1QIi8OsbvB5CO/JbZQYkhlt64=; b=qDsLraTjXN8uG6OkvuY3Djh3mbyQE0uEkbhgevjjF4IYKKKdvX9wufHLwi39dcdEfY +lFXaK9wVLaqIMYpZrFuexe/eHjoNJv6PwU5dG2RoHX2iDsWKjzh8gUPioxl/2lFxXK9 ghd5x6d7QqL/tc5fC4lLsNJVZgwBRmfJUKeTZA1LWz9ylY4i2KKDzo2gVxz5AOM7TxL/ sJyWwKEX8HGiUrezPYZNn87V0c1l1PPm2Z2Q0UDROG2sPlhx7e6nSFJj8UJ0j46HsQ0m p2JWOO9Y2yWzDH06OyW/HrQKidOIxTVvDYAoGpIYW4UJJlhh1hxjS+woQY0W+iDzj7rV fOMQ== X-Gm-Message-State: APt69E2Wkm23uIx8bghpEtHfizb6POfWI8MPYQMBkWC7koM2TW/R+6NQ Z3DVzSGuINrY59aUlG7/qr7+6g== X-Google-Smtp-Source: ADUXVKIzlrXzOEmwzTqqWsndLXJnsDDeR9Q4aETnWpEHZt4QuF2gVkZjaDkq2rqfLnQkwxBK3aM3GQ== X-Received: by 2002:a1c:dc41:: with SMTP id t62-v6mr9648527wmg.42.1529342221743; Mon, 18 Jun 2018 10:17:01 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z16-v6sm23025007wro.41.2018.06.18.10.17.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 10:17:00 -0700 (PDT) Date: Mon, 18 Jun 2018 18:16:59 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Hua Jing , semihalf-dabros-jan , Grzegorz Jaszczyk Message-ID: <20180618171659.ieub5gbbn2arblpc@bivouac.eciton.net> References: <1529266325-18371-1-git-send-email-mw@semihalf.com> <1529266325-18371-19-git-send-email-mw@semihalf.com> <20180618162340.pihbaer7zylpushy@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v2 18/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 17:17:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 18, 2018 at 06:27:47PM +0200, Marcin Wojtas wrote: > 2018-06-18 18:23 GMT+02:00 Leif Lindholm : > > On Sun, Jun 17, 2018 at 10:11:58PM +0200, Marcin Wojtas wrote: > >> This patch introduces new library callback (ArmadaSoCDescMdioGet ()), > >> which dynamically allocates and fills MV_SOC_MDIO_DESC structure with > >> the SoC description of Mdio controllers. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Marcin Wojtas > >> --- > >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 ++++ > >> Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 15 ++++++++++ > >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 29 ++++++++++++++++++++ > >> 3 files changed, 50 insertions(+) > >> > >> diff --git a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > >> index f372ca0..c864f94 100644 > >> --- a/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > >> +++ b/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > >> @@ -38,6 +38,12 @@ > >> #define MV_SOC_COMPHY_MUX_BITS 4 > >> > >> // > >> +// Platform description of MDIO controllers > >> +// > >> +#define MV_SOC_MDIO_BASE(Cp) (MV_SOC_CP_BASE ((Cp)) + 0x12A200) > > > > Still pointless double parentheses around this Cp :) > > Save that for a single patch later on, as commented on earlier patch > > in set. > > (This version already fixes the bug.) > > I can quickly update each patch, unless you really wish to do it > separately. Please confirm your preferences. Ah, right, I got it in my head this file existed before this series, but that isn't the case. Sure, if you can update them all on initial introduction, that'd be nice. Best Regards, Leif