From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F62B210F30A9 for ; Mon, 18 Jun 2018 10:44:09 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id d2-v6so17711440wrm.10 for ; Mon, 18 Jun 2018 10:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PmBtQW1pyl4ubBDCiCZOchiNDErXPcMSMoF1+kIlk/I=; b=VpcJQRw2W70u+NQQR3TvwK7yJ1/Jhb229Bmt8sPiHwNp5GWE86xRhwQXSzEQ6w8x+O DvXOGZfLqXS0PpTtGMiqpjg+QuBGg1DxBuGZ7aOf2OrWNSm9OaSt+pnvZlhDeWZUgLo2 NL327ELU7ivupV4wi7jP+voeGFwxZN3BTlm2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PmBtQW1pyl4ubBDCiCZOchiNDErXPcMSMoF1+kIlk/I=; b=JAOhlMhFnhdclyK80IVTuTSL9J5L9JpK0EM7/tFyH+PeWCE4wNe0sqxlWd4ZMvY/pD f8+PIsYo2i8BoGeAuYKYwe5+qN947twvjW2CVvebpnUAOM/RlwfuzaxNTMur9kDZDI+O f4b+32zVeweKw7s9AnYt1rQinzN9m/u5baRtMgxJ51/fmaaNkaXigPXOWllX2cSR9RBR ASnfLGdKhVECT1U8NnBMcjo5uV4rpRSAfJXuqDdBeYVTmif3QkRvXjQ1y8hEzy7gpsyB FuSi+9zahmngTr23ourIGv/WsuVJ/9y2BivfRFZ9+Cl+dK0jg5eIsp0OMx3Y52fsYeIi +xbw== X-Gm-Message-State: APt69E08+hHqhylaTK6nvErXIg69+n3AYGLi70iqKOtig7+x3+FYqMZS uJAiXQAVLYdFXYBi7iOyXApePg== X-Google-Smtp-Source: ADUXVKI5Z9Vli9pyH3KeQ9fEAI91+pbKmi7fCzqfDk9SPHWUJ7JvJnjgZ61F4NJ879P34Tmgdvz9dQ== X-Received: by 2002:adf:eccd:: with SMTP id s13-v6mr11906389wro.160.1529343848179; Mon, 18 Jun 2018 10:44:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n7-v6sm18116585wrr.39.2018.06.18.10.44.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 10:44:07 -0700 (PDT) Date: Mon, 18 Jun 2018 18:44:05 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, liming.gao@intel.com, yonghong.zhu@intel.com Message-ID: <20180618174405.ntx73wrikd4wv44q@bivouac.eciton.net> References: <20180618173456.18050-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180618173456.18050-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] BaseTools/tools_def CLANG35: add NOOPT build target X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 17:44:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 18, 2018 at 07:34:56PM +0200, Ard Biesheuvel wrote: > Create the missing NOOPT target for CLANG35 (which is ARM and AARCH64 > only), and align it with the other toolchains: NOOPT has optimizations > disabled entirely (for source level debugging), DEBUG has some -O1 > enabled just like CLANG38. Can I ask for a slight rewording above? This changes the behaviour of CLANG35 DEBUG from -O0 to -O1. (This is the correct thing, but the message isn't 100% clear on this.) Mention this, and: Reviewed-by: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index ab57f9c706e3..11a79029b890 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -5675,8 +5675,9 @@ DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64 > *_CLANG35_ARM_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_ARM_TARGET) > *_CLANG35_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS) > > - DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > + DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1 > RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz > + NOOPT_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > > ################## > # CLANG35 AARCH64 definitions > @@ -5697,8 +5698,9 @@ RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P > *_CLANG35_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_AARCH64_TARGET) > *_CLANG35_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) > > - DEBUG_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > + DEBUG_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1 > RELEASE_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz > + NOOPT_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > > #################################################################################### > # > -- > 2.17.1 >