From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4C334210FB9EA for ; Mon, 18 Jun 2018 12:42:04 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id r15-v6so15996577wmc.1 for ; Mon, 18 Jun 2018 12:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f16TkPpclqtmt1CUd49qqgCBZGa4LXBytBix1vlhuao=; b=XQar3V4F+TDjzSapO3zOO18z9oHmC4kLEwl97CYUg5pDHMugzwM91AKLrIR0MaQX/C upqv8VatXwJSFoclLheJeztx7mKXZh+AKgXb2RndlB01O+mcQvvjMSASHahw9EU3Mvgp MxhTkl9dotBzw4MjRaoWqGegqh++ZqOmaEPhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f16TkPpclqtmt1CUd49qqgCBZGa4LXBytBix1vlhuao=; b=CBqS1Y9+n+gxhjCwrDYGrYlQ0GhfbqB4ZRFTQ8Xb89VB7nPUFgg6Q5b/up48+qIbC5 0w5ljuTvLwpU7JM2V6Tjnf/FNR4RNSmFcSpjVSdW7c4mjKNnOg2LovhmNN7FnMGXnhCB caasDSj+LiCSOLbWwM9EFRZ+1kdAaGj+hgf7kqHmeW+Q55Ck9RqLQ1LbIULap87PkbVs DKN3MHjLXy9htJ5H9mETejP48uz7UVP7UU2ZE1Mr5YCouiRTSZVhY/1MCOUmnW781cTs r2n4evPgRKllbW4P+xZ6s82XyZCveOLbnvQh7+aQfLJ48mD5k7zSRszAmol3/tJAUkqw vJKA== X-Gm-Message-State: APt69E2umwqW73ZuK3pgtRsu3BUbUtDUYP/dryCNGLoa1P3Q6gKgQQk7 QedUECG79yDKSzFO95b2t9br3CJK0VY= X-Google-Smtp-Source: ADUXVKJx7PrtV4qZoS5DqBmMwIn1DXzaesObVoF6E+4nLjC0/niG3Ckhbx/nGlxh4gbHtHB/JfzksA== X-Received: by 2002:a1c:450d:: with SMTP id s13-v6mr9929122wma.72.1529350923426; Mon, 18 Jun 2018 12:42:03 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d102-v6sm11717250wma.10.2018.06.18.12.42.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 12:42:02 -0700 (PDT) Date: Mon, 18 Jun 2018 20:42:00 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180618194200.t2umfeewglsx4adg@bivouac.eciton.net> References: <20180618181603.26242-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180618181603.26242-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 19:42:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 18, 2018 at 08:16:03PM +0200, Ard Biesheuvel wrote: > Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the > one in the ArmMtlNullLib implementation (rather than the other way around, > since edk2-platforms has a conflicting implementation as well) Eew. But yeah, this looks like the practical fix. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/Include/Library/ArmMtlLib.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h > index 4218a741e5eb..48641258ba68 100644 > --- a/ArmPkg/Include/Library/ArmMtlLib.h > +++ b/ArmPkg/Include/Library/ArmMtlLib.h > @@ -68,7 +68,7 @@ typedef struct { > EFI_STATUS > MtlWaitUntilChannelFree ( > IN MTL_CHANNEL *Channel, > - IN UINT64 TimeOutInMicroSeconds > + IN UINTN TimeOutInMicroSeconds > ); > > /** Return the address of the message payload. > -- > 2.17.1 >