* [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree
@ 2018-06-18 18:16 Ard Biesheuvel
2018-06-18 19:42 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-06-18 18:16 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, Ard Biesheuvel
Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the
one in the ArmMtlNullLib implementation (rather than the other way around,
since edk2-platforms has a conflicting implementation as well)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/Include/Library/ArmMtlLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h
index 4218a741e5eb..48641258ba68 100644
--- a/ArmPkg/Include/Library/ArmMtlLib.h
+++ b/ArmPkg/Include/Library/ArmMtlLib.h
@@ -68,7 +68,7 @@ typedef struct {
EFI_STATUS
MtlWaitUntilChannelFree (
IN MTL_CHANNEL *Channel,
- IN UINT64 TimeOutInMicroSeconds
+ IN UINTN TimeOutInMicroSeconds
);
/** Return the address of the message payload.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree
2018-06-18 18:16 [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree Ard Biesheuvel
@ 2018-06-18 19:42 ` Leif Lindholm
2018-06-18 19:50 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-06-18 19:42 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Mon, Jun 18, 2018 at 08:16:03PM +0200, Ard Biesheuvel wrote:
> Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the
> one in the ArmMtlNullLib implementation (rather than the other way around,
> since edk2-platforms has a conflicting implementation as well)
Eew.
But yeah, this looks like the practical fix.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmPkg/Include/Library/ArmMtlLib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h
> index 4218a741e5eb..48641258ba68 100644
> --- a/ArmPkg/Include/Library/ArmMtlLib.h
> +++ b/ArmPkg/Include/Library/ArmMtlLib.h
> @@ -68,7 +68,7 @@ typedef struct {
> EFI_STATUS
> MtlWaitUntilChannelFree (
> IN MTL_CHANNEL *Channel,
> - IN UINT64 TimeOutInMicroSeconds
> + IN UINTN TimeOutInMicroSeconds
> );
>
> /** Return the address of the message payload.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree
2018-06-18 19:42 ` Leif Lindholm
@ 2018-06-18 19:50 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-06-18 19:50 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 18 June 2018 at 21:42, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Jun 18, 2018 at 08:16:03PM +0200, Ard Biesheuvel wrote:
>> Align the prototype of ArmMtlLib's MtlWaitUntilChannelFree () with the
>> one in the ArmMtlNullLib implementation (rather than the other way around,
>> since edk2-platforms has a conflicting implementation as well)
>
> Eew.
> But yeah, this looks like the practical fix.
>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 1f739a851ce8ea8c9c4d9c4c7a5862fd44ab6ab4
>> ---
>> ArmPkg/Include/Library/ArmMtlLib.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Include/Library/ArmMtlLib.h b/ArmPkg/Include/Library/ArmMtlLib.h
>> index 4218a741e5eb..48641258ba68 100644
>> --- a/ArmPkg/Include/Library/ArmMtlLib.h
>> +++ b/ArmPkg/Include/Library/ArmMtlLib.h
>> @@ -68,7 +68,7 @@ typedef struct {
>> EFI_STATUS
>> MtlWaitUntilChannelFree (
>> IN MTL_CHANNEL *Channel,
>> - IN UINT64 TimeOutInMicroSeconds
>> + IN UINTN TimeOutInMicroSeconds
>> );
>>
>> /** Return the address of the message payload.
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-18 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-18 18:16 [PATCH] ArmPkg/ArmMtlLib: fix prototype inconsistency in MtlWaitUntilChannelFree Ard Biesheuvel
2018-06-18 19:42 ` Leif Lindholm
2018-06-18 19:50 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox