Re: [PATCH] EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Jun 18, 2018 at 10:49:18PM +0200, Ard Biesheuvel wrote:
> Clang complains about left shifting a negative value being undefined.

As well it should.

>   EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c:151:30:
>   error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
>   OutputData = (UINT8)((~DLAB<<7)|((BreakSet<<6)|((Parity<<3)|((StopBits<<2)| Data))));
> 
> Redefine all bit pattern constants as unsigned to work around this.

So, I'm totally OK with this and
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
but ...
would it be worth fixing up BIT0-31 in Base.h and use those?

/
    Leif

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> index 069d87ca780d..7931d1ac4e2b 100644
> --- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> +++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
> @@ -40,11 +40,11 @@
>  //---------------------------------------------
>  // UART Register Bit Defines
>  //---------------------------------------------
> -#define LSR_TXRDY               0x20
> -#define LSR_RXDA                0x01
> -#define DLAB                    0x01
> -#define ENABLE_FIFO             0x01
> -#define CLEAR_FIFOS             0x06
> +#define LSR_TXRDY               0x20U
> +#define LSR_RXDA                0x01U
> +#define DLAB                    0x01U
> +#define ENABLE_FIFO             0x01U
> +#define CLEAR_FIFOS             0x06U
>  
>  
>  
> -- 
> 2.17.1
>