Re: [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

[Achin Gupta <achin.gupta@arm.com>]

Hi Jiewen,

On Mon, Jun 18, 2018 at 03:12:46PM +0000, Yao, Jiewen wrote:
> Yes. I think so.
>
> However, I found the V3 just contains partial of the patch. It is hard to find some V2 and some V3.
> Also this series includes multiple package. We need different package maintainer to push different patches.
>
> I recommend we do in this way:
> Please split this big one into 3 - BaseTool patch, ArmPkg patch, and StandaloneMmPkg patch.
>
> Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can push ArmPkg patch, and I can help push StandaloneMmPkg patch.

Thomas and Sugosh will refactor the patches and repost since Supreeth is on
holiday. I started late but would like to finish reviewing the Arm specific bits
in the StandaloneMmPkg before they are merged. Will not take more than 2
days. Could you please merge after I ack. Hope that is fine?

cheers,
Achin

>
> Thank you
> Yao Jiewen
>
> > -----Original Message-----
> > From: Thomas Abraham [mailto:thomas.abraham@arm.com]
> > Sent: Monday, June 18, 2018 6:07 AM
> > To: Sughosh Ganu <sng.lists@gmail.com>
> > Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> > edk2-devel@lists.01.org; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core
> > Interface for AARCH64 Platforms ***
> >
> > On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu <sng.lists@gmail.com> wrote:
> > > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
> > > <supreeth.venkatesh@arm.com> wrote:
> > >> ***
> > >> This patchset v3 contains only the patches that got feedback/comments
> > frome the previous revision v2.
> > >> The patches are
> > >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> > >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point
> > library.
> > >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
> > >>
> > >> Changes Since v2:
> > >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update
> > header file for MM modules."
> > >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit
> > "StandaloneMmPkg: Add an AArch64 specific entry point library."
> > >>
> > >> Changes Since v1:
> > >> (*) Reorder and Reword commits.
> > >> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> > >> (*) Address Review Comments from Achin, Jiewen and Daniil.
> > >> ***
> > >> Supreeth Venkatesh (17):
> > >>   ArmPkg: Add PCDs needed for MM communication driver.
> > >>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> > >>   ArmPkg/Include: Add MM interface SVC return codes.
> > >>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> > >>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
> > >>   StandaloneMmPkg: Delete StandaloneMmPkg file.
> > >>   StandaloneMmPkg/FvLib: Add a common FV Library for management
> > mode.
> > >>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory
> > check
> > >>     library.
> > >>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation
> > library.
> > >>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
> > >>   StandaloneMmPkg: MM driver entry point library.
> > >>   StandaloneMmPkg/Core: Implementation of Standalone MM Core
> > Module.
> > >>   StandaloneMmPkg: Add an AArch64 specific entry point library.
> > >>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
> > >>   StandaloneMmPkg: Describe the declaration and definition files.
> > >>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
> > >>   BaseTools/AutoGen: Update header file for MM modules.
> > >
> > > Tested all changes for RAS error injection and error handling on
> > > SGI575 platform.
> > >
> > > Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > >
> > > -sughosh
> >
> > There have been no further comments on this series. Can this patch
> > series be merged?
> >
> > Thanks,
> > Thomas.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel