public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT
@ 2018-06-20 16:42 Sami Mujawar
  2018-06-20 17:00 ` Evan Lloyd
  2018-06-21 12:26 ` Leif Lindholm
  0 siblings, 2 replies; 3+ messages in thread
From: Sami Mujawar @ 2018-06-20 16:42 UTC (permalink / raw)
  To: edk2-devel
  Cc: Arvind Chauhan, Daniil Egranov, Thomas Panakamattam Abraham,
	leif.lindholm, evan.lloyd, Matteo.Carlini, Stephanie.Hughes-Fitt,
	nd

The OEM Table ID length cannot be more than 8 characters.
Moreover, the ACPICA iASL compiler patch "Add error messages
for ACPI tables with bad OEM and OEM Table IDs" dated
13 April 2018 [20180413]
(https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0d9c4d6885e44)
introduced checks for the OEM Table ID length. If the
OEM Table ID length is more than 8 characters in the
DSDT/SSDT table's DefinitionBlock(), it flags them as
an error.

This patch adjusts the length of the OEM Table ID to
8 characters in the DSDT and SSDT tables.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/289_fix_dsdt_definitionblock_v1

Notes:
    v1:
    - Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
index 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e9677139f2ab3deac5520e 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl
@@ -12,7 +12,7 @@
 
 **/
 
-DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) {
+DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) {
   Scope(_SB) {
     //
     // Processor
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-21 12:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-20 16:42 [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT Sami Mujawar
2018-06-20 17:00 ` Evan Lloyd
2018-06-21 12:26 ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox