Re: [PATCH v3 02/20] BaseTools: Refactor python except statements

[Gary Lin <glin@suse.com>]

On Thu, Jun 21, 2018 at 12:43:28PM +0800, Gary Lin wrote:
> Convert "except ... ," to "except ... as" to be compatible with python3.
> Based on "futurize -f lib2to3.fixes.fix_except"
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  
-->8--

> -    except IOError as (errno, strerror):
> +    except IOError as xxx_todo_changeme:
> +        (errno, strerror) = xxx_todo_changeme.args
>          file_list.close()
>          if not Opt.silent:
>              sys.stderr.write("I/O ERROR : %s : %s\n" % (str(errno), strerror))
> @@ -100,7 +101,8 @@ def ShellCommandResults(CmdLine, Opt):
>              sys.stderr.flush()
>          returnValue = errno
>  
> -    except OSError as (errno, strerror):
> +    except OSError as xxx_todo_changeme1:
> +        (errno, strerror) = xxx_todo_changeme1.args
>          file_list.close()
>          if not Opt.silent:
>              sys.stderr.write("OS ERROR : %s : %s\n" % (str(errno), strerror))
> @@ -210,13 +212,15 @@ def RevertCmd(Filename, Opt):
>              sys.stderr.write("Subprocess ERROR : %s\n" % err_val)
>              sys.stderr.flush()
>  
> -    except IOError as (errno, strerror):
> +    except IOError as xxx_todo_changeme2:
> +        (errno, strerror) = xxx_todo_changeme2.args
>          if not Opt.silent:
>              sys.stderr.write("I/O ERROR : %d : %s\n" % (str(errno), strerror))
>              sys.stderr.write("ERROR : this command failed : %s\n" % CmdLine)
>              sys.stderr.flush()
>  
> -    except OSError as (errno, strerror):
> +    except OSError as xxx_todo_changeme3:
> +        (errno, strerror) = xxx_todo_changeme3.args
>          if not Opt.silent:
>              sys.stderr.write("OS ERROR : %d : %s\n" % (str(errno), strerror))
>              sys.stderr.write("ERROR : this command failed : %s\n" % CmdLine)

I forgot to fix the naming of the tuple arguments. Will post a new patch
if necessary.

Gary Lin