From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69AFA210E8D64 for ; Thu, 21 Jun 2018 05:26:13 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id h10-v6so2986309wrq.8 for ; Thu, 21 Jun 2018 05:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3sdkCxPr2druy1UcgvuGuRfp/dApYavixa2xAHnF/P8=; b=YJBQx2TWzEw1YVUp2deW9t8+F7BVlcpJwERZJhCfYLgAJTCGt5rV684WeHy+26/kqx rHuF6s9FzREhVx66jfUYiJRbrm4Cw4/O3QGIG6sLC8jOgVLEu0Hy1v/fRqLXQpzMXrCc fdGxx4+TpYDzYGkEjg0cyQCifpAIQr2Fs3sa0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3sdkCxPr2druy1UcgvuGuRfp/dApYavixa2xAHnF/P8=; b=B9GZNCYS3vKkJhr0lrcb83+QsKduFQ7Nv78Tj2ES2/rjH+VwFVrehz3Gs4iXEeAc8k 5cQpN9/jO46LNKxxuvIHpYyQvXNkTe3KsHULAHONc5F/ZCviGOSiSx0QUUWYdCl8RfRx cTjii2rwY1UEGttJRs2pG9Nm4hyAmtObYUxrp8lUBusEr35m5NEXkA5Ipbhpvxob8/ny iu50Ou4Vw9e+tU6fU8YKKMaOmBBWIIN0ATXPDO/5gYKyB3zhz0FIWwf1Xa0EMXQ4dNN2 XtP7puXULzo7vqkQYxs+e8lEKLusCMhnV1ZBZ1+YLi4HYdT4aOUUvbcJmJPoAMzzPy6v s7og== X-Gm-Message-State: APt69E2k/tCbtjPREpFMPFKmXnM2TuHwYKyqHrmPlm+VEqI0xtbO04Km DeSfUKYXyr0RFsXWg0cqz9bRaw== X-Google-Smtp-Source: ADUXVKJgx4eXiY7Ghzci0BL76OWurt7xyWolY8Rew3ZbMyk89KPJ3MU82gKcXL91BEcnr+sUfVl/oA== X-Received: by 2002:adf:ff88:: with SMTP id j8-v6mr2010857wrr.137.1529583971293; Thu, 21 Jun 2018 05:26:11 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z13-v6sm5301630wrr.71.2018.06.21.05.26.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 05:26:09 -0700 (PDT) Date: Thu, 21 Jun 2018 13:26:08 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , evan.lloyd@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180621122608.ovzcoqrxm25tcljp@bivouac.eciton.net> References: <20180620164254.5076-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180620164254.5076-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 12:26:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 20, 2018 at 05:42:54PM +0100, Sami Mujawar wrote: > The OEM Table ID length cannot be more than 8 characters. > Moreover, the ACPICA iASL compiler patch "Add error messages > for ACPI tables with bad OEM and OEM Table IDs" dated > 13 April 2018 [20180413] > (https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0d9c4d6885e44) > introduced checks for the OEM Table ID length. If the > OEM Table ID length is more than 8 characters in the > DSDT/SSDT table's DefinitionBlock(), it flags them as > an error. > > This patch adjusts the length of the OEM Table ID to > 8 characters in the DSDT and SSDT tables. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar Reviewed-by: Leif Lindholm Pushed as 693bbd8747. > --- > > The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/289_fix_dsdt_definitionblock_v1 > > Notes: > v1: > - Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI] > > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > index 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e9677139f2ab3deac5520e 100644 > --- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Dsdt.asl > @@ -12,7 +12,7 @@ > > **/ > > -DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) { > +DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) { > Scope(_SB) { > // > // Processor > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >