From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B127E210D2139 for ; Thu, 21 Jun 2018 08:06:17 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id r15-v6so5761863wmc.1 for ; Thu, 21 Jun 2018 08:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Eqv7r7BAT4llmuyM1Q2LZzTHUWU6YmuJnb2aAw/nB8M=; b=FsOtyxkb0FvXvi3+lpSwQe/bBj9cjw0Cc/Bvhf2Cy5158pNrlUKBhxDJ7o0T2mnse5 Mf+Iu5KF+on4ZJZPmMM7qoi5rtwEvzzQgiwnEWhHFtBRYodK7JVF9opSK5FZvvxKn/y3 T9Qe1Oib+kIOIjRf8cpYgZWCj/T+51WK4dIHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Eqv7r7BAT4llmuyM1Q2LZzTHUWU6YmuJnb2aAw/nB8M=; b=T3GI2fc1EaEuGS5+IqPAYohO2gX0pIDrQ76nCz6n0OpYXurNagOQSf7l7+GDSqowcz kYWDY069DGbbF2WdhEUrelJEDdjH1VKgIF5cgRW6PewegR2UweBPUbl/ip5eq5Zo6c1A +/4eTlKo1kDqeXcyJhyFBNYOf4MaCwkk7D33f64nDcimi3iB1PL9FlKMVYsJOUBMnQ4u fQijcRAZCZReGG4NsAshnSCqYvJpta5bFvMSLT7h6MB68rGrHc8PjyXd8CCzoXIB/nGD LN8Znj9IrjNmXKxjYCYueUkwejFEWo+q6rEsUYjF9cEj2faUchmwIEMFc8ipqpZ3Pj++ 1U9g== X-Gm-Message-State: APt69E3oC7M7U8CgEy8moY7dncbPlGvP6EUKD3iIj2eVNl+qGVOQbNFb C2pCENGCZplC/WFnthJ/Tn7mTQ== X-Google-Smtp-Source: ADUXVKL9T1hCzirh91Lg7oErXjZ/d5QhR+L14Kpl6InYywBMnX5+LQl6fVtp1qRU/M48z4zSHOnmUg== X-Received: by 2002:a1c:f308:: with SMTP id q8-v6mr5335302wmq.6.1529593575911; Thu, 21 Jun 2018 08:06:15 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b186-v6sm6504742wmh.4.2018.06.21.08.06.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 08:06:14 -0700 (PDT) Date: Thu, 21 Jun 2018 16:06:12 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jinghua@marvell.com, jsd@semihalf.com, jaz@semihalf.com Message-ID: <20180621150612.ycpse3i2h6bq67n4@bivouac.eciton.net> References: <1529362724-9244-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1529362724-9244-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH v3 00/25] Armada hardware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 15:06:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote: > Hi, > > The third version of the patchset comes with the single Signed-off-by, > Reviewed-by's and corrected double parentheses in one of the headers. > For the details, please check the changelog below. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180619 > > I'm looking forward to review and any comments/remarks. Looks good. Pushed as 070938aa96..5e43d10d55. / Leif > Best regards, > Marcin > > Changelog: > v2 -> v3 > * 1,3,4,5 > - remove additional Signed-off-by > > * 1,4,8,9,10,11,12,14,15,16,17,18,19,22,23,24,25 > - add Leif's RBs > > * 8,11,15,18 > - remove double parentheses in Armada7k8kSoCDescLib.h > > v1 -> v2 > * All > - rebase on top of the master branch > - remove internal review residues from the commit logs > - increase all files version to 0x1A > - use UINTN, where applicable > - add Armada7k8kSoCDescLib definitions to a local header > - remove assignments from variables declarations > > * 2,3,5-7,13,20-21 > - Add Leif's RBs > > * 1 > - add parentheses in macros > - simplify loop and values assignments > > * 4 > - add parentheses in if's > - rename table and remove usage of MVHW_DEV_ENABLED > - remove redundant NULL check in MvBoardDescFree () > - add comments about using UINT8 * arrays, remove casting > - use MV prefix in the signature > - sort PCDs > > * 9 > - drop TODO comment > - rename table and remove usage of MVHW_DEV_ENABLED > - add comments about using UINT8 * arrays, remove casting > > * 11 > - simplify ArmadaSoCDescXhciGet > > * 12 > - remove TODO in comment > - sort variables, PCDs and assignments > - add comments about UINT8 arrays, remove casting > - rename table and remove usage of MVHW_DEV_ENABLED > > * 16 > - remove TODO in comment > - sort variables, PCDs and assignments > - add comments about UINT8 arrays, remove casting > - rename table and remove usage of MVHW_DEV_ENABLED > > * 22 > - simplify loop and values assignments > > *23 > - remove TODO in comment > - sort variables, PCDs and assignments > - add comments about UINT8 arrays, remove casting > - rename table and remove usage of MVHW_DEV_ENABLED > > *25 > - add parentheses in if condition > > Marcin Wojtas (21): > Marvell/Library: Introduce ArmadaBoardDescLib class > Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol > Marvell/Library: RealTimeClockLib: Simplify obtaining base address > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information > Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support > Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI > Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI > Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC > Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information > Marvell/Drivers: MvBoardDesc: Extend protocol with ComPhy support > Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information > Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support > Marvell/Drivers: MvMdioDxe: Enable 64bit addressing > Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information > Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support > Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC > Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency > > jinghua (4): > Marvell/Library: Introduce ArmadaSoCDescLib class > Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL > Marvell/Drivers: MvBoardDesc: Introduce board description driver > Marvell/Armada7k8k: Enable board description driver compilation > > Silicon/Marvell/Marvell.dec | 8 +- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 + > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 +- > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 2 +- > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 2 - > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 ++ > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 2 +- > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 70 +++ > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 1 + > Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 1 + > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 2 +- > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf | 6 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 6 +- > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 9 +- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 79 +++ > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h | 57 ++ > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 87 +++ > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 146 +++++ > Silicon/Marvell/Include/Library/MvHwDescLib.h | 290 ---------- > Silicon/Marvell/Include/Library/UtmiPhyLib.h | 2 + > Silicon/Marvell/Include/Protocol/BoardDesc.h | 118 ++++ > Silicon/Marvell/Include/Protocol/Mdio.h | 4 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 + > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 5 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 279 +++++++++ > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 29 +- > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 597 ++++++++++++++++++++ > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 37 +- > Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c | 41 +- > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 4 +- > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 43 +- > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 100 ++-- > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 50 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 74 ++- > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 65 +-- > 37 files changed, 1727 insertions(+), 537 deletions(-) > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h > create mode 100644 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > create mode 100644 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > delete mode 100644 Silicon/Marvell/Include/Library/MvHwDescLib.h > create mode 100644 Silicon/Marvell/Include/Protocol/BoardDesc.h > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > -- > 2.7.4 >